Merge branch 'main' into feat/port-test-exception

Author: bavulapati

.github/copilot-instructions.md

@@ -6,7 +6,7 @@ Node-API Conformance Test Suite: A pure ECMAScript test suite for Node-API imple
 
 ## General Principles
 - **Keep it minimal**: Avoid unnecessary dependencies, configuration, or complexity
-- **Pure ECMAScript tests**: To lower the barrier for implementors to run the tests, all tests are written as single files of pure ECMAScript, with no import / export statements and no use of Node.js runtime APIs outside of the language standard (such as `process`, `require`, `node:*` modules).
+- **Pure ECMAScript tests**: To lower the barrier for implementors to run the tests, all tests are written as single files of pure ECMAScript, with no import / export statements and no use of Node.js runtime APIs outside of the language standard (such as `process`, `require`, `node:*` modules). Test files are evaluated as ES modules, which are always in strict mode, so drop the `'use strict'` directive when porting a file that carries one.
 - **TypeScript tooling**: The tooling around the tests are written in TypeScript and expects to be ran in a Node.js compatible runtime with type-stripping enabled. Never rely on `ts-node`, `node --loader ts-node/esm`, or `--experimental-strip-types`; use only stable, built-in Node.js capabilities.
 - **Implementor Flexibility**: Native code building and loading is delegated to implementors, with the test-suite providing defaults that work for Node.js.
 - **Extra convenience**: Extra (generated) code is provided to make it easier for implementors to load and run tests, such as extra package exports exposing test functions that implementors can integrate with their preferred test frameworks.

PORTING.md

@@ -66,7 +66,7 @@ Tests covering the engine-specific part of Node-API, defined in `js_native_api.h
 | `test_object`                | Not ported | Hard       |
 | `test_promise`               | Ported ✅  | Easy       |
 | `test_properties`            | Ported ✅  | Easy       |
-| `test_reference`             | Not ported | Medium     |
+| `test_reference`             | Ported ✅  | Medium     |
 | `test_reference_double_free` | Ported ✅  | Easy       |
 | `test_sharedarraybuffer`     | Ported ✅  | Medium     |
 | `test_string`                | Ported ✅  | Medium     |

tests/harness/features.js

@@ -1,5 +1,3 @@
-'use strict';
-
 assert.ok(
   typeof experimentalFeatures === 'object' && experimentalFeatures !== null,
   'Expected a global experimentalFeatures object',

tests/harness/load-addon.js

@@ -1,5 +1,3 @@
-'use strict';
-
 if (typeof loadAddon !== 'function') {
   throw new Error('Expected a global loadAddon function');
 }

tests/harness/napi-version.js

@@ -1,5 +1,3 @@
-'use strict';
-
 // napiVersion is a positive integer
 if (typeof napiVersion !== 'number' || napiVersion < 1 || !Number.isInteger(napiVersion)) {
   throw new Error('Expected a global napiVersion that is a positive integer');

tests/harness/skip-test.js

@@ -1,5 +1,3 @@
-'use strict';
-
 // skipTest is a function
 if (typeof skipTest !== 'function') {
   throw new Error('Expected a global skipTest function');

tests/js-native-api/3_callbacks/test.js

@@ -1,4 +1,3 @@
-'use strict';
 const addon = loadAddon('3_callbacks');
 
 addon.RunCallback(mustCall((msg) => {

tests/js-native-api/4_object_factory/test.js

@@ -1,4 +1,3 @@
-'use strict';
 const addon = loadAddon('4_object_factory');
 
 const obj1 = addon('hello');

tests/js-native-api/5_function_factory/test.js

@@ -1,4 +1,3 @@
-'use strict';
 const addon = loadAddon('5_function_factory');
 
 const fn = addon();

tests/js-native-api/7_factory_wrap/test.js

@@ -1,4 +1,3 @@
-'use strict';
 const test = loadAddon('7_factory_wrap');
 
 assert.strictEqual(test.finalizeCount, 0);