Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Commit d81f653

Browse files
committed
test: fix n-api test_constructor
1 parent cde5789 commit d81f653

File tree

1 file changed

+22
-6
lines changed
  • test/addons-napi/test_constructor

1 file changed

+22
-6
lines changed

test/addons-napi/test_constructor/test.js

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,13 @@ assert.strictEqual(test_object.readwriteValue, 1);
1313
test_object.readwriteValue = 2;
1414
assert.strictEqual(test_object.readwriteValue, 2);
1515

16-
assert.throws(() => { test_object.readonlyValue = 3; },
17-
/^TypeError: Cannot assign to read only property 'readonlyValue' of object '#<MyObject>'$/);
16+
assert.throws(
17+
() => { test_object.readonlyValue = 3; },
18+
common.engineSpecificMessage({
19+
v8: /^TypeError: Cannot assign to read only property 'readonlyValue' of object '#<MyObject>'$/,
20+
chakracore: /^TypeError: Assignment to read-only properties is not allowed in strict mode$/
21+
})
22+
);
1823

1924
assert.ok(test_object.hiddenValue);
2025

@@ -36,13 +41,24 @@ assert.ok(!propertyNames.includes('readonlyAccessor2'));
3641
test_object.readwriteAccessor1 = 1;
3742
assert.strictEqual(test_object.readwriteAccessor1, 1);
3843
assert.strictEqual(test_object.readonlyAccessor1, 1);
39-
assert.throws(() => { test_object.readonlyAccessor1 = 3; },
40-
/^TypeError: Cannot assign to read only property 'readonlyAccessor1' of object '#<MyObject>'$/);
44+
assert.throws(
45+
() => { test_object.readonlyAccessor1 = 3; },
46+
common.engineSpecificMessage({
47+
v8: /^TypeError: Cannot assign to read only property 'readonlyAccessor1' of object '#<MyObject>'$/,
48+
chakracore: /^TypeError: Assignment to read-only properties is not allowed in strict mode$/
49+
})
50+
);
51+
4152
test_object.readwriteAccessor2 = 2;
4253
assert.strictEqual(test_object.readwriteAccessor2, 2);
4354
assert.strictEqual(test_object.readonlyAccessor2, 2);
44-
assert.throws(() => { test_object.readonlyAccessor2 = 3; },
45-
/^TypeError: Cannot assign to read only property 'readonlyAccessor2' of object '#<MyObject>'$/);
55+
assert.throws(
56+
() => { test_object.readonlyAccessor2 = 3; },
57+
common.engineSpecificMessage({
58+
v8: /^TypeError: Cannot assign to read only property 'readonlyAccessor2' of object '#<MyObject>'$/,
59+
chakracore: /^TypeError: Assignment to read-only properties is not allowed in strict mode$/
60+
})
61+
);
4662

4763
// validate that static properties are on the class as opposed
4864
// to the instance

0 commit comments

Comments
 (0)