Skip to content

Commit 13d7b2d

Browse files
committed
fix: comply with markdown style guidelines
The markdown style linting for our repos requires `*` instead of `-` for unordered lists. Because ncu-team uses `-`, it results in failing lints in some repos, thus requiring manual changes to the output. Use `*` instead so that becomes unnecessary. I had this problem in nodejs/TSC#1189. Refs: nodejs/TSC@3cbcd5a
1 parent 919ec3b commit 13d7b2d

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

lib/team_info.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ function byLogin(a, b) {
88
}
99

1010
function getContact({ login, url, name, email }) {
11-
if (!name) return `- [@${login}](${url})`;
12-
return `- [@${login}](${url}) - ${name}`;
11+
if (!name) return `* [@${login}](${url})`;
12+
return `* [@${login}](${url}) - ${name}`;
1313
}
1414

1515
function key(org, team) {

test/fixtures/ncu_team_sync_expected.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22

33
<!-- ncu-team-sync.team(nodejs/automation-collaborators) -->
44

5-
- [@Bar](https://github.com/Bar) - Bar Bar
6-
- [@foo](https://github.com/foo) - Mr. foo
7-
- [@quo](https://github.com/quo) - Ms. Quo
5+
* [@Bar](https://github.com/Bar) - Bar Bar
6+
* [@foo](https://github.com/foo) - Mr. foo
7+
* [@quo](https://github.com/quo) - Ms. Quo
88

99
<!-- ncu-team-sync end -->
1010

1111
## nodejs/bots
1212

1313
<!-- ncu-team-sync.team(nodejs/bots) -->
1414

15-
- [@nodejs-github-bot](https://github.com/nodejs-github-bot) - Node.js GitHub Bot
15+
* [@nodejs-github-bot](https://github.com/nodejs-github-bot) - Node.js GitHub Bot
1616

1717
<!-- ncu-team-sync end -->

test/fixtures/ncu_team_sync_out.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22

33
<!-- ncu-team-sync.team(nodejs/automation-collaborators) -->
44

5-
- [@Bar](https://github.com/Bar) - Bar Bar
6-
- [@foo](https://github.com/foo) - Mr. foo
7-
- [@quo](https://github.com/quo) - Ms. Quo
5+
* [@Bar](https://github.com/Bar) - Bar Bar
6+
* [@foo](https://github.com/foo) - Mr. foo
7+
* [@quo](https://github.com/quo) - Ms. Quo
88

99
<!-- ncu-team-sync end -->
1010

1111
## nodejs/bots
1212

1313
<!-- ncu-team-sync.team(nodejs/bots) -->
1414

15-
- [@nodejs-github-bot](https://github.com/nodejs-github-bot) - Node.js GitHub Bot
15+
* [@nodejs-github-bot](https://github.com/nodejs-github-bot) - Node.js GitHub Bot
1616

1717
<!-- ncu-team-sync end -->

test/unit/team_info.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ import TeamInfo from '../../lib/team_info.js';
77
import { readJSON, readFile, path as getPath } from '../fixtures/index.js';
88

99
const collabList =
10-
`- [@Bar](https://github.com/Bar) - Bar Bar
11-
- [@foo](https://github.com/foo) - Mr. foo
12-
- [@quo](https://github.com/quo) - Ms. Quo`;
10+
`* [@Bar](https://github.com/Bar) - Bar Bar
11+
* [@foo](https://github.com/foo) - Mr. foo
12+
* [@quo](https://github.com/quo) - Ms. Quo`;
1313

1414
describe('TeamInfo', function() {
1515
let request;

0 commit comments

Comments
 (0)