Address some feedback

Author: codebytere

lib/promote_release.js

@@ -116,6 +116,13 @@ class ReleasePromotion {
     // There will be cherry-pick conflicts the Releaser will
     // need to resolve, so confirm they've been resolved before
     // proceeding with next steps.
+    cli.separator();
+    cli.info(`After cherry-picking:
+      * The version macros in src/node_version.h should contain whatever values
+      were previously on master.
+      * NODE_VERSION_IS_RELEASE should be 0.
+    `);
+    cli.separator();
     const didResolveConflicts = await cli.prompt(
       'Finished resolving cherry-pick conflicts?', { defaultAnswer: true });
     if (!didResolveConflicts) {
@@ -186,11 +193,12 @@ class ReleasePromotion {
     const components = releaseCommitMessage.split(' ');
 
     // Parse out release date.
-    if (!components[0].match(/\d{4}-\d{2}-\d{2}/)) {
+    const match = components[0].match(/\d{4}-\d{2}-\d{2}/);
+    if (!match) {
       cli.error(`Release commit contains invalid date: ${components[0]}`);
       return;
     }
-    this.date = components[0];
+    this.date = match[0];
 
     // Parse out release version.
     const version = semver.clean(components[2]);
@@ -243,7 +251,7 @@ class ReleasePromotion {
       `v${version}`,
       this.getCommitSha(),
       '-sm',
-      `"${this.date} Node.js v${version} ${releaseInfo} Release"`
+      `${this.date} Node.js v${version} ${releaseInfo} Release`
     ];
 
     return runSync(secureTag, secureTagOptions);
@@ -271,7 +279,7 @@ class ReleasePromotion {
     await fs.writeFile(filePath, arr.join('\n'));
 
     const workingOnVersion =
-      `${versionComponents.major}.${versionComponents.minor}.${patchVersion}`;
+      `v${versionComponents.major}.${versionComponents.minor}.${patchVersion}`;
 
     // Create 'Working On' commit.
     runSync('git', ['add', filePath]);