chore(wpt): throw better error when wpt path does not exist

Author: jazelly

lib/github/tree.js

@@ -29,13 +29,29 @@ export default class GitHubTree {
 
   async _getLastCommit() {
     const { request, owner, repo, branch, path } = this;
+    console.log('asdasd', COMMIT_QUERY, {
+      owner,
+      repo,
+      branch,
+      path
+    });
     const data = await request.gql(COMMIT_QUERY, {
       owner,
       repo,
       branch,
       path
     });
-    return data.repository.ref.target.history.nodes[0].oid;
+
+    console.log('data', data);
+    const targetHistoryNodes = data.repository.ref.target.history.nodes;
+    if (!targetHistoryNodes.length) {
+      this.cli.stopSpinner(
+        `Cannot find WPT for "${path}". Please check the WPT name.`,
+        this.cli.SPINNER_STATUS.FAILED
+      );
+      process.exit();
+    }
+    return targetHistoryNodes[0].oid;
   }
 
   /**

test/unit/wpt_updater.test.js

@@ -0,0 +1,54 @@
+import { describe, it, before, after } from 'node:test';
+import TestCLI from '../fixtures/test_cli.js';
+import sinon from 'sinon';
+
+import { WPTUpdater } from '../../lib/wpt/index.js';
+
+describe('WPTUpdater', function() {
+  const UNKNOWN_PATH = 'unknown path';
+  let request;
+  let wptUpdater;
+  let nodedir;
+  let cli;
+  let path;
+  const emptyData = {
+    repository:
+    {
+      ref: { target: { history: { nodes: [] } } }
+    }
+  };
+
+  before(() => {
+    cli = new TestCLI();
+    request = {
+      gql: sinon.stub()
+    };
+    nodedir = '.';
+    request.gql.withArgs(
+      'LastCommit',
+      {
+        owner: 'web-platform-tests',
+        repo: 'wpt',
+        branch: 'master',
+        path: UNKNOWN_PATH
+      }
+    ).returns(Promise.resolve(emptyData));
+  });
+
+  after(() => {
+    cli.clearCalls();
+  });
+
+  it('exits with meaningful error when WPT name not found', async() => {
+    path = UNKNOWN_PATH;
+    wptUpdater = new WPTUpdater(path, cli, request, nodedir);
+    await wptUpdater.update();
+    cli.assertCalledWith(
+      {
+        warn: [[
+          `Cannot find WPT for "${path}". Please check the WPT name.`,
+          { newline: true }
+        ]]
+      }, { ignore: ['startSpinner', 'updateSpinner'] });
+  });
+});