fixup! feat(ncu-config): add support for partially encrypted config files

lazy auth

Author: aduh95

lib/auth.js

@@ -60,29 +60,70 @@ function encode(name, token) {
   return Buffer.from(`${name}:${token}`).toString('base64');
 }
 
+function setOwnProperty(target, key, value) {
+  return Object.defineProperty(target, key, {
+    __proto__: null,
+    configurable: true,
+    enumerable: true,
+    value
+  });
+}
+
 // TODO: support jenkins only...or not necessary?
 // TODO: make this a class with dependency (CLI) injectable for testing
 async function auth(
   options = { github: true },
   githubAuth = ghauth) {
-  const result = {};
-  if (options.github) {
-    let username;
-    let token;
-    try {
-      ({ username, token } = getMergedConfig());
-    } catch (e) {
-      // Ignore error and prompt
-    }
+  const result = {
+    get github() {
+      let username;
+      let token;
+      try {
+        ({ username, token } = getMergedConfig());
+      } catch (e) {
+        // Ignore error and prompt
+      }
+
+      check(username, token);
+      const github = encode(username, token);
+      setOwnProperty(result, 'github', github);
+      return github;
+    },
 
-    if (!username || !token) {
+    get jenkins() {
+      const { username, jenkins_token } = getMergedConfig();
+      if (!username || !jenkins_token) {
+        errorExit(
+          'Get your Jenkins API token in https://ci.nodejs.org/me/security ' +
+          'and run the following command to add it to your ncu config: ' +
+          'ncu-config --global set -x jenkins_token'
+        );
+      };
+      check(username, jenkins_token);
+      const jenkins = encode(username, jenkins_token);
+      setOwnProperty(result, 'jenkins', jenkins);
+      return jenkins;
+    },
+
+    get h1() {
+      const { h1_username, h1_token } = getMergedConfig();
+      check(h1_username, h1_token);
+      const h1 = encode(h1_username, h1_token);
+      setOwnProperty(result, 'h1', h1);
+      return h1;
+    }
+  };
+  if (options.github) {
+    const config = getMergedConfig();
+    if (!Object.hasOwn(config, 'token') || !Object.hasOwn(config, 'username')) {
       process.stdout.write(
         'If this is your first time running this command, ' +
         'follow the instructions to create an access token' +
         '. If you prefer to create it yourself on Github, ' +
         'see https://github.com/nodejs/node-core-utils/blob/main/README.md.\n');
       const credentials = await tryCreateGitHubToken(githubAuth);
-      username = credentials.user;
+      const username = credentials.user;
+      let token;
       try {
         token = await encryptValue(credentials.token);
       } catch (err) {
@@ -95,38 +136,9 @@ async function auth(
       });
       // Try again reading the file
       clearCachedConfig();
-      ({ username, token } = getMergedConfig());
     }
-    check(username, token);
-    result.github = encode(username, token);
   }
 
-  if (options.jenkins) {
-    const { username, jenkins_token } = getMergedConfig();
-    if (!username || !jenkins_token) {
-      errorExit(
-        'Get your Jenkins API token in https://ci.nodejs.org/me/security ' +
-        'and run the following command to add it to your ncu config: ' +
-        'ncu-config --global set -x jenkins_token'
-      );
-    };
-    check(username, jenkins_token);
-    result.jenkins = encode(username, jenkins_token);
-  }
-
-  if (options.h1) {
-    const { h1_username, h1_token } = getMergedConfig();
-    if (!h1_username || !h1_token) {
-      errorExit(
-        'Get your HackerOne API token in ' +
-        'https://docs.hackerone.com/organizations/api-tokens.html ' +
-        'and run the following command to add it to your ncu config: ' +
-        'ncu-config --global set -x h1_token or ' +
-        'ncu-config --global set h1_username USERNAME'
-      );
-    };
-    result.h1 = encode(h1_username, h1_token);
-  }
   return result;
 }