Properly trim getCommitSha result

codebytere · targos · codebytere · commit 42131b556e82 · 2020-05-04T08:45:14.000-07:00
Co-Authored-By: Michaël Zasso &lt;targos@protonmail.com&gt;
diff --git a/lib/promote_release.js b/lib/promote_release.js
@@ -215,7 +215,7 @@ class ReleasePromotion {
   }
 
   getCommitSha(position = 0) {
-    return runSync('git', ['rev-parse', `HEAD~${position}`]);
+    return runSync('git', ['rev-parse', `HEAD~${position}`]).trim();
   }
 
   get owner() {

Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,7 @@ class ReleasePromotion {`
`215`	`215`	`}`
`216`	`216`
`217`	`217`	`getCommitSha(position = 0) {`
`218`		- return runSync('git', ['rev-parse', `HEAD~${position}`]);
	`218`	+ return runSync('git', ['rev-parse', `HEAD~${position}`]).trim();
`219`	`219`	`}`
`220`	`220`
`221`	`221`	`get owner() {`