Skip to content

Commit 692c6b7

Browse files
committed
fix: run release script asynchronously
1 parent 7d23d70 commit 692c6b7

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

lib/promote_release.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const { promises: fs } = require('fs');
55
const semver = require('semver');
66

77
const { getMergedConfig } = require('./config');
8-
const { runSync } = require('./run');
8+
const { runSync, runAsync } = require('./run');
99
const auth = require('./auth');
1010
const PRData = require('./pr_data');
1111
const PRChecker = require('./pr_checker');
@@ -101,7 +101,7 @@ class ReleasePromotion {
101101

102102
// Merge vX.Y.Z-proposal into vX.x.
103103
cli.startSpinner('Merging proposal branch');
104-
await this.mergeProposalBranch();
104+
this.mergeProposalBranch();
105105
cli.stopSpinner('Merged proposal branch');
106106

107107
// Cherry pick release commit to master.
@@ -151,7 +151,7 @@ class ReleasePromotion {
151151
const keyPath = await cli.prompt(
152152
`Please enter the path to your ssh key (Default ${defaultKeyPath}): `,
153153
{ questionType: 'input', defaultAnswer: defaultKeyPath });
154-
this.promoteAndSignRelease(keyPath);
154+
await this.promoteAndSignRelease(keyPath);
155155

156156
cli.separator();
157157
cli.ok(`Release promotion for ${version} complete.\n`);
@@ -292,7 +292,7 @@ class ReleasePromotion {
292292
]);
293293
}
294294

295-
async mergeProposalBranch() {
295+
mergeProposalBranch() {
296296
const { stagingBranch, versionComponents, version } = this;
297297

298298
const releaseBranch = `v${versionComponents.major}.x`;
@@ -313,8 +313,8 @@ class ReleasePromotion {
313313
return runSync('git', ['push', 'upstream', tagVersion]);
314314
}
315315

316-
promoteAndSignRelease(keyPath) {
317-
return runSync('./tools/release.sh', ['-i', keyPath]);
316+
async promoteAndSignRelease(keyPath) {
317+
await runAsync('./tools/release.sh', ['-i', keyPath]);
318318
}
319319

320320
cherryPickToMaster() {

0 commit comments

Comments
 (0)