feat: add --skip-more-than to ncu-ci to skip real test failures

Author: joyeecheung

bin/ncu-ci.js

@@ -215,6 +215,11 @@ const args = yargs(hideBin(process.argv))
     default: false,
     type: 'boolean'
   })
+  .option('skip-more-than', {
+    describe: 'Skip jobs that fail more than <limit> builds, when --stat is true, default to 10.',
+    type: 'number',
+    default: Infinity
+  })
   .option('nobuild', {
     describe: 'If running cigtm, whether or not jobid is citgm-nobuild.',
     type: 'boolean',
@@ -325,15 +330,19 @@ class CICommand {
       cli.separator('');
 
       let build;
+      let { skipMoreThan } = argv;
+      if (argv.stats && argv.skipMoreThan === Infinity) {
+        skipMoreThan = 10;
+      }
       switch (job.type) {
         case 'health':
           build = new HealthBuild(cli, request, job.ciType, job.builds);
           break;
         case PR:
-          build = new PRBuild(cli, request, job.jobid);
+          build = new PRBuild(cli, request, job.jobid, skipMoreThan);
           break;
         case COMMIT:
-          build = new CommitBuild(cli, request, job.jobid);
+          build = new CommitBuild(cli, request, job.jobid, skipMoreThan);
           break;
         case CITGM:
         case CITGM_NOBUILD:

lib/ci/build-types/commit_build.js

@@ -20,10 +20,11 @@ const {
 } = CIFailureParser;
 
 export class CommitBuild extends TestBuild {
-  constructor(cli, request, id) {
+  constructor(cli, request, id, skipMoreThan) {
     const path = `job/node-test-commit/${id}/`;
     const tree = COMMIT_TREE;
     super(cli, request, path, tree);
+    this.skipMoreThan = skipMoreThan;
   }
 
   getBuilds({ result, subBuilds }) {
@@ -89,6 +90,11 @@ export class CommitBuild extends TestBuild {
       return { result, builds, failures };
     }
 
+    if (builds.failed.length > this.skipMoreThan) {
+      cli.log(`Failed ${builds.failed.length} builds (> ${this.skipMoreThan}), skipping`);
+      return { result, builds, failures: [] };
+    }
+
     cli.startSpinner(`Querying failures of ${path}`);
     const promises = builds.failed.map(({ jobName, buildNumber, url }) => {
       if (jobName.includes('fanned')) {

lib/ci/build-types/pr_build.js

@@ -15,11 +15,11 @@ const {
 } = CIFailureParser;
 
 export class PRBuild extends TestBuild {
-  constructor(cli, request, id) {
+  constructor(cli, request, id, skipMoreThan) {
     const path = `job/node-test-pull-request/${id}/`;
     const tree = PR_TREE;
     super(cli, request, path, tree);
-
+    this.skipMoreThan = skipMoreThan;
     this.commitBuild = null;
   }
 
@@ -78,7 +78,7 @@ export class PRBuild extends TestBuild {
       result, subBuilds: allBuilds, changeSet, actions, timestamp
     };
     const commitBuildId = commitBuild.buildNumber;
-    this.commitBuild = new CommitBuild(cli, request, commitBuildId);
+    this.commitBuild = new CommitBuild(cli, request, commitBuildId, this.skipMoreThan);
     const { builds, failures } = await this.commitBuild.getResults(buildData);
 
     // Set up aliases for display