ci: handle 404 responses

Author: joyeecheung

lib/ci/ci_failure_parser.js

@@ -32,10 +32,11 @@ const JS_TEST_FAILURE = 'JS_TEST_FAILURE';
 const CC_TEST_FAILURE = 'CC_TEST_FAILURE';
 const JENKINS_FAILURE = 'JENKINS_FAILURE';
 const GIT_FAILURE = 'GIT_FAILURE';
+const NCU_FAILURE = 'NCU_FAILURE';
 
 const FAILURE_TYPES = {
   BUILD_FAILURE, JS_TEST_FAILURE, CC_TEST_FAILURE,
-  JENKINS_FAILURE, GIT_FAILURE
+  JENKINS_FAILURE, GIT_FAILURE, NCU_FAILURE
 };
 
 class CIResult {
@@ -93,6 +94,15 @@ class GitFailure extends CIResult {
   }
 }
 
+// Failures in this tool, we wrap them to avoid exceptions when
+// walking the CI
+class NCUFailure extends CIResult {
+  constructor(ctx, reason) {
+    super(ctx, reason);
+    this.type = NCU_FAILURE;
+  }
+}
+
 function failureMatcher(Failure, patterns, ctx, text) {
   for (const pattern of patterns) {
     const matches = text.match(pattern.pattern);
@@ -251,14 +261,16 @@ CIFailureParser.FAILURE_CONSTRUCTORS = {
   JENKINS_FAILURE: JenkinsFailure,
   JS_TEST_FAILURE: JSTestFailure,
   CC_TEST_FAILURE: CCTestFailure,
-  GIT_FAILURE: GitFailure
+  GIT_FAILURE: GitFailure,
+  NCU_FAILURE: NCUFailure
 };
 CIFailureParser.CIResult = CIResult;
 CIFailureParser.FAILURE_TYPES_NAME = {
   BUILD_FAILURE: 'Build Failure',
   JENKINS_FAILURE: 'Jenkins Failure',
   JS_TEST_FAILURE: 'JSTest Failure',
   CC_TEST_FAILURE: 'CCTest Failure',
-  GIT_FAILURE: 'Git Failure'
+  GIT_FAILURE: 'Git Failure',
+  NCU_FAILURE: 'node-core-utils failure'
 };
 module.exports = CIFailureParser;

lib/ci/ci_result_parser.js

@@ -7,10 +7,12 @@ const Cache = require('../cache');
 const CIFailureParser = require('./ci_failure_parser');
 const {
   FAILURE_TYPES: {
-    BUILD_FAILURE
+    BUILD_FAILURE,
+    NCU_FAILURE
   },
   FAILURE_CONSTRUCTORS: {
-    [BUILD_FAILURE]: BuildFailure
+    [BUILD_FAILURE]: BuildFailure,
+    [NCU_FAILURE]: NCUFailure
   },
   CIResult,
   FAILURE_TYPES_NAME
@@ -148,19 +150,28 @@ class Job {
   }
 
   async parseConsoleText() {
-    const text = await this.getConsoleText();
-    const parser = new CIFailureParser(this, text);
-    const results = parser.parse();
+    let text;
+    try {
+      text = await this.getConsoleText();
+    } catch (err) {
+      this.failures = [
+        new NCUFailure({
+          url: this.consoleUrl, builtOn: this.builtOn
+        }, err.message)
+      ];
+      return this.failures;
+    }
 
-    if (results) {
-      this.failures = results;
-      return results;
+    const parser = new CIFailureParser(this, text);
+    let results = parser.parse();
+    if (!results) {
+      results = [
+        new CIResult({ url: this.jobUrl, builtOn: this.builtOn }, 'Unknown')
+      ];
     }
 
-    this.failures = [
-      new CIResult({ url: this.jobUrl, builtOn: this.builtOn }, 'Unknown')
-    ];
-    return this.failures;
+    this.failures = results;
+    return results;
   }
 }
 
@@ -505,8 +516,16 @@ class CommitBuild extends TestBuild {
   // Get the failures and their reasons of this build
   async getResults(data) {
     const { path, cli, request } = this;
+
     if (!data) {
-      data = await this.getBuildData();
+      try {
+        data = await this.getBuildData();
+      } catch (err) {
+        this.failures = [
+          new NCUFailure({ url: this.apiUrl }, err.message)
+        ];
+        return this.failures;
+      }
     }
     this.setBuildData(data);
     // No builds at all
@@ -562,7 +581,16 @@ class PRBuild extends TestBuild {
   // Get the failures and their reasons of this build
   async getResults() {
     const { cli, request } = this;
-    const data = await this.getBuildData();
+
+    let data;
+    try {
+      data = await this.getBuildData();
+    } catch (err) {
+      this.failures = [
+        new NCUFailure({ url: this.apiUrl }, err.message)
+      ];
+      return this.failures;
+    }
     const {
       result, subBuilds, changeSet, actions, timestamp
     } = data;
@@ -661,7 +689,16 @@ class FannedBuild extends Job {
   // Get the failures and their reasons of this build
   async getResults() {
     const { cli, request } = this;
-    const data = await this.getAPIData();
+
+    let data;
+    try {
+      data = await this.getAPIData();
+    } catch (err) {
+      this.failures = [
+        new NCUFailure({ url: this.apiUrl }, err.message)
+      ];
+      return this.failures;
+    }
     this.builtOn = data.builtOn;
 
     if (!data.subBuilds.length) {
@@ -707,7 +744,15 @@ class LinterBuild extends Job {
   }
 
   async getResults() {
-    const data = await this.getAPIData();
+    let data;
+    try {
+      data = await this.getAPIData();
+    } catch (err) {
+      this.failures = [
+        new NCUFailure(this, err.message)
+      ];
+      return this.failures;
+    }
     this.builtOn = data.builtOn;
     return this.parseConsoleText();
   }
@@ -725,7 +770,18 @@ class NormalBuild extends Job {
 
   async getResults() {
     const { cli, request } = this;
-    const { result, runs, builtOn } = await this.getAPIData();
+
+    let data;
+    try {
+      data = await this.getAPIData();
+    } catch (err) {
+      this.failures = [
+        new NCUFailure({ url: this.apiUrl }, err.message)
+      ];
+      return this.failures;
+    }
+
+    const { result, runs, builtOn } = data;
     this.builtOn = builtOn;
 
     if (result !== FAILURE) {
@@ -782,7 +838,15 @@ class TestRun extends Job {
   }
 
   async getData() {
-    const data = await this.getAPIData();
+    let data;
+    try {
+      data = await this.getAPIData();
+    } catch (err) {
+      this.failures = [
+        new NCUFailure({ url: this.apiUrl }, err.message)
+      ];
+      return this.failures;
+    }
     if (data.actions && data.actions.find(item => item.causes)) {
       const actions = data.actions.find(item => item.causes);
       this.cause = actions.causes[0];