Fix verification spinners

codebytere · codebytere · commit a1c3ef1c76f7 · 2020-05-20T11:45:45.000-07:00
diff --git a/lib/promote_release.js b/lib/promote_release.js
@@ -47,8 +47,9 @@ class ReleasePromotion {
         cli.warn(`Aborting release promotion for version ${version}`);
         return;
       }
+    } else {
+      cli.stopSpinner('Jenkins CI is passing');
     }
-    cli.stopSpinner('Jenkins CI is passing');
 
     cli.startSpinner('Verifying GitHub CI status');
     if (!githubCIReady) {
@@ -59,8 +60,9 @@ class ReleasePromotion {
         cli.warn(`Aborting release promotion for version ${version}`);
         return;
       }
+    } else {
+      cli.stopSpinner('GitHub CI is passing');
     }
-    cli.stopSpinner('GitHub CI is passing');
 
     cli.startSpinner('Verifying PR approval status');
     if (!isApproved) {
@@ -72,8 +74,9 @@ class ReleasePromotion {
         cli.warn(`Aborting release promotion for version ${version}`);
         return;
       }
+    } else {
+      cli.stopSpinner(`#${prid} has necessary approvals`);
     }
-    cli.stopSpinner(`#${prid} has necessary approvals`);
 
     // Create and sign the release tag.
     const shouldTagAndSignRelease = await cli.prompt(

Original file line number	Diff line number	Diff line change
`@@ -47,8 +47,9 @@ class ReleasePromotion {`
`47`	`47`	cli.warn(`Aborting release promotion for version ${version}`);
`48`	`48`	`return;`
`49`	`49`	`}`
	`50`	`+ } else {`
	`51`	`+ cli.stopSpinner('Jenkins CI is passing');`
`50`	`52`	`}`
`51`		`- cli.stopSpinner('Jenkins CI is passing');`
`52`	`53`
`53`	`54`	`cli.startSpinner('Verifying GitHub CI status');`
`54`	`55`	`if (!githubCIReady) {`
`@@ -59,8 +60,9 @@ class ReleasePromotion {`
`59`	`60`	cli.warn(`Aborting release promotion for version ${version}`);
`60`	`61`	`return;`
`61`	`62`	`}`
	`63`	`+ } else {`
	`64`	`+ cli.stopSpinner('GitHub CI is passing');`
`62`	`65`	`}`
`63`		`- cli.stopSpinner('GitHub CI is passing');`
`64`	`66`
`65`	`67`	`cli.startSpinner('Verifying PR approval status');`
`66`	`68`	`if (!isApproved) {`
`@@ -72,8 +74,9 @@ class ReleasePromotion {`
`72`	`74`	cli.warn(`Aborting release promotion for version ${version}`);
`73`	`75`	`return;`
`74`	`76`	`}`
	`77`	`+ } else {`
	`78`	+ cli.stopSpinner(`#${prid} has necessary approvals`);
`75`	`79`	`}`
`76`		- cli.stopSpinner(`#${prid} has necessary approvals`);
`77`	`80`
`78`	`81`	`// Create and sign the release tag.`
`79`	`82`	`const shouldTagAndSignRelease = await cli.prompt(`