land: optional deprecations update (#450)

node-core-utils is also used on other repositories across the Node.js
Org where deprecations are not logged into a file. Making it opt-out
allows node-core-utils to still be used on those repositories.

Author: mmarchini

lib/landing_session.js

@@ -95,17 +95,20 @@ class LandingSession extends Session {
     }
 
     // Check for and maybe assign any unmarked deprecations in the codebase.
-    const unmarkedDeprecations = await getUnmarkedDeprecations();
-    const unmarkedDepCount = unmarkedDeprecations.length;
-    if (unmarkedDepCount > 0) {
-      cli.startSpinner('Assigning deprecation numbers to DEPOXXX items');
-
-      // Update items then stage files and amend the last commit.
-      await updateDeprecations(unmarkedDeprecations);
-      await runAsync('git', ['add', 'doc', 'lib', 'src', 'test']);
-      await runAsync('git', ['commit', '--amend', '--no-edit']);
-
-      cli.stopSpinner(`Updated ${unmarkedDepCount} DEPOXXX items in codebase`);
+    if (this.updateDeprecations !== 'yes') {
+      const unmarkedDeprecations = await getUnmarkedDeprecations();
+      const unmarkedDepCount = unmarkedDeprecations.length;
+      if (unmarkedDepCount > 0) {
+        cli.startSpinner('Assigning deprecation numbers to DEPOXXX items');
+
+        // Update items then stage files and amend the last commit.
+        await updateDeprecations(unmarkedDeprecations);
+        await runAsync('git', ['add', 'doc', 'lib', 'src', 'test']);
+        await runAsync('git', ['commit', '--amend', '--no-edit']);
+
+        cli
+          .stopSpinner(`Updated ${unmarkedDepCount} DEPOXXX items in codebase`);
+      }
     }
 
     cli.ok('Patches applied');

lib/session.js

@@ -60,6 +60,7 @@ class Session {
       readme: this.readme,
       waitTimeSingleApproval: this.waitTimeSingleApproval,
       waitTimeMultiApproval: this.waitTimeMultiApproval,
+      updateDeprecations: this.updateDeprecations,
       ciType: this.ciType,
       prid: this.prid
     };
@@ -109,6 +110,10 @@ class Session {
     return path.join(this.ncuDir, `${this.prid}`);
   }
 
+  get updateDeprecations() {
+    return this.config.updateDeprecations || 'yes';
+  }
+
   startLanding() {
     writeJson(this.sessionPath, {
       state: STARTED,