fix(ncu-config): do not override encrypted values silently

Author: aduh95

lib/config.js

@@ -70,8 +70,12 @@ function addEncryptedPropertyGetter(target, key, input) {
         return value;
       },
       set(newValue) {
-        addEncryptedPropertyGetter(target, key, newValue) ||
-            setOwnProperty(target, key, newValue);
+        if (!addEncryptedPropertyGetter(target, key, newValue)) {
+          throw new Error(
+            'Refusing to override an encrypted value with a non-encrypted one. ' +
+            'Please use an encrypted one, or delete the config key first.'
+          );
+        }
       }
     });
   }
@@ -99,7 +103,7 @@ export function getConfig(configType, dir) {
   }
 };
 
-export function getConfigPath(configType, dir) {
+function getConfigPath(configType, dir) {
   switch (configType) {
     case GLOBAL_CONFIG:
       return getNcurcPath();
@@ -117,7 +121,7 @@ export function getConfigPath(configType, dir) {
   }
 };
 
-export function writeConfig(configType, obj, dir) {
+function writeConfig(configType, obj, dir) {
   const configPath = getConfigPath(configType, dir);
   const encryptedConfigPath = configPath + '.gpg';
   if (existsSync(encryptedConfigPath)) {