fix: return value for validateLint (#482)

codebytere · web-flow · commit e379e9f94688 · 2020-08-19T09:19:09.000-07:00
diff --git a/lib/landing_session.js b/lib/landing_session.js
@@ -137,8 +137,12 @@ class LandingSession extends Session {
       return true;
     }
 
-    const linted = await runAsync('make', ['lint']);
-    return linted;
+    try {
+      await runAsync('make', ['lint']);
+      return true;
+    } catch {
+      return false;
+    }
   }
 
   async tryCompleteLanding(patch) {
@@ -216,6 +220,8 @@ class LandingSession extends Session {
         '`git node land --continue`.');
         process.exit(1);
       }
+    } else {
+      cli.ok('Lint passed cleanly');
     }
 
     this.startAmending();

Original file line number	Diff line number	Diff line change
`@@ -137,8 +137,12 @@ class LandingSession extends Session {`
`137`	`137`	`return true;`
`138`	`138`	`}`
`139`	`139`
`140`		`- const linted = await runAsync('make', ['lint']);`
`141`		`- return linted;`
	`140`	`+ try {`
	`141`	`+ await runAsync('make', ['lint']);`
	`142`	`+ return true;`
	`143`	`+ } catch {`
	`144`	`+ return false;`
	`145`	`+ }`
`142`	`146`	`}`
`143`	`147`
`144`	`148`	`async tryCompleteLanding(patch) {`
`@@ -216,6 +220,8 @@ class LandingSession extends Session {`
`216`	`220`	'`git node land --continue`.');
`217`	`221`	`process.exit(1);`
`218`	`222`	`}`
	`223`	`+ } else {`
	`224`	`+ cli.ok('Lint passed cleanly');`
`219`	`225`	`}`
`220`	`226`
`221`	`227`	`this.startAmending();`