Skip to content

Commit ee1fdbf

Browse files
committed
fix(git-node): ignore all non-gha nodes when checking for GitHub CI
1 parent 9224469 commit ee1fdbf

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

lib/pr_checker.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ const GITHUB_SUCCESS_CONCLUSIONS = ['SUCCESS', 'NEUTRAL', 'SKIPPED'];
2929
const FAST_TRACK_RE = /^Fast-track has been requested by @(.+?)\. Please 👍 to approve\.$/;
3030
const FAST_TRACK_MIN_APPROVALS = 2;
3131
const GIT_CONFIG_GUIDE_URL = 'https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork';
32-
const IGNORED_CHECK_SLUGS = ['dependabot', 'codecov'];
3332

3433
// eslint-disable-next-line no-extend-native
3534
Array.prototype.findLastIndex ??= function findLastIndex(fn) {
@@ -374,9 +373,10 @@ export default class PRChecker {
374373

375374
// GitHub new Check API
376375
for (const { status, conclusion, app } of checkSuites.nodes) {
377-
if (app && IGNORED_CHECK_SLUGS.includes(app.slug)) {
376+
if (app.slug !== 'github-actions') {
378377
// Ignore Dependabot and Codecov check suites.
379-
// They are expected to show up sometimes and never complete.
378+
// They are expected to show up on PRs whose head branch is not on a
379+
// fork and never complete.
380380
continue;
381381
}
382382

0 commit comments

Comments
 (0)