land: fast-track code and learn PRs

Co-Authored-By: targos <[email protected]>

Author: 2 people

lib/pr_checker.js

@@ -115,6 +115,7 @@ class PRChecker {
     const labels = pr.labels.nodes.map((l) => l.name);
 
     const isFastTracked = labels.includes('fast-track');
+    const isCodeAndLearn = labels.includes('code-and-learn');
     const isSemverMajor = labels.includes('semver-major');
 
     const dateStr = new Date(pr.createdAt).toUTCString();
@@ -124,6 +125,9 @@ class PRChecker {
     // these labels removed because that doesn't make sense
     if (isFastTracked) {
       cli.info('This PR is being fast-tracked');
+    } else if (isCodeAndLearn) {
+      cli.info('This PR is being fast-tracked because ' +
+               'it is from a Code and Learn event');
     }
 
     if (approved.length === 0 || requestedChanges.length > 0) {
@@ -148,7 +152,7 @@ class PRChecker {
     const timeLeftSingle = WAIT_TIME_SINGLE_APPROVAL - hoursFromCreateTime;
 
     if (approved.length >= 2) {
-      if (isFastTracked) {
+      if (isFastTracked || isCodeAndLearn) {
         return true;
       }
       if (timeLeftMulti < 0) {

test/unit/pr_checker.test.js

@@ -370,6 +370,52 @@ describe('PRChecker', () => {
       cli.assertCalledWith(expectedLogs);
     });
 
+    it('should fast track code-and-learn PRs', () => {
+      const cli = new TestCLI();
+
+      const expectedLogs = {
+        ok:
+         [ [ 'Approvals: 4' ],
+           [ '- Foo User (@foo): https://github.com/nodejs/node/pull/16438#pullrequestreview-71480624' ],
+           [ '- Quux User (@Quux): LGTM' ],
+           [ '- Baz User (@Baz): https://github.com/nodejs/node/pull/16438#pullrequestreview-71488236' ],
+           [ '- Bar User (@bar) (TSC): lgtm' ] ],
+        info:
+         [ [ 'This PR was created on Fri, 30 Nov 2018 17:50:44 GMT' ],
+           [ 'This PR is being fast-tracked because ' +
+             'it is from a Code and Learn event' ]
+         ]
+      };
+
+      const pr = Object.assign({}, firstTimerPR, {
+        createdAt: LT_48H,
+        labels: {
+          nodes: [
+            { name: 'code-and-learn' }
+          ]
+        }
+      });
+
+      const data = {
+        pr,
+        reviewers: allGreenReviewers,
+        comments: commentsWithCI,
+        reviews: approvingReviews,
+        commits: [],
+        collaborators,
+        authorIsNew: () => true,
+        getThread() {
+          return PRData.prototype.getThread.call(this);
+        }
+      };
+      const checker = new PRChecker(cli, data, argv);
+
+      cli.clearCalls();
+      const status = checker.checkReviewsAndWait(new Date(NOW));
+      assert(status);
+      cli.assertCalledWith(expectedLogs);
+    });
+
     it('should warn about approvals and CI for fast-tracked PR', () => {
       const cli = new TestCLI();