ci: handle empty matches correctly

Author: joyeecheung

lib/ci/ci_failure_parser.js

@@ -105,6 +105,9 @@ const FAILURE_FILTERS = [{
       return null;
     }
     const nonFlaky = matches.filter((m) => !m.includes('# TODO :'));
+    if (!nonFlaky.length) {
+      return null;
+    }
     return unique(nonFlaky).map(
       match => new JSTestFailure(ctx, match)
     );
@@ -176,7 +179,7 @@ const FAILURE_FILTERS = [{
     const pattern = /fatal: .+/g;
     const matches = text.match(pattern);
     if (!matches) {
-      return [];
+      return null;
     }
     const reason = unique(matches).join('\n');
     return [new BuildFailure(ctx, reason)];
@@ -187,7 +190,7 @@ const FAILURE_FILTERS = [{
       pattern: /FATAL: .+/g,
       context: { index: -1, contextBefore: 0, contextAfter: 5 }
     }, {
-      match: /error: .+/g,
+      pattern: /error: .+/g,
       context: { index: 0, contextBefore: 0, contextAfter: 5 }
     }, {
       pattern: /make.*: write error/mg,