ci: parse console if all sub builds succeed in a failed build

Also added a few cases of build failure patterns

Author: joyeecheung

lib/ci/ci_failure_parser.js

@@ -189,12 +189,12 @@ const FAILURE_FILTERS = [{
     const patterns = [{
       pattern: /FATAL: .+/g,
       context: { index: -1, contextBefore: 0, contextAfter: 5 }
-    }, {
-      pattern: /error: .+/g,
-      context: { index: 0, contextBefore: 0, contextAfter: 5 }
     }, {
       pattern: /make.*: write error/mg,
       context: { index: 0, contextBefore: 0, contextAfter: 3 }
+    }, {
+      pattern: /error: .+/g,
+      context: { index: 0, contextBefore: 0, contextAfter: 5 }
     }, {
       pattern: /Makefile:.+failed/g,
       context: { index: 0, contextBefore: 0, contextAfter: 5 }
@@ -204,6 +204,15 @@ const FAILURE_FILTERS = [{
     }, {
       pattern: /warning: failed .+/g,
       context: { index: 0, contextBefore: 0, contextAfter: 3 }
+    }, {
+      pattern: /Build timed out/g,
+      context: { index: 0, contextBefore: 0, contextAfter: 1 }
+    }, {
+      pattern: /bash: line /g,
+      context: { index: 0, contextBefore: 0, contextAfter: 1 }
+    }, {
+      pattern: /Cannot rebase: You have unstaged changes/g,
+      context: { index: 0, contextBefore: 0, contextAfter: 1 }
     }];
     return buildFailureMatcher(patterns, ctx, text);
   }

lib/ci/ci_result_parser.js

@@ -143,6 +143,22 @@ class Job {
       .replace(/\//g, '-')
       .replace(/-$/, '');
   }
+
+  async parseConsoleText() {
+    const text = await this.getConsoleText();
+    const parser = new CIFailureParser(this, text);
+    const results = parser.parse();
+
+    if (results) {
+      this.failures = results;
+      return results;
+    }
+
+    this.failures = [
+      new CIResult({ url: this.jobUrl, builtOn: this.builtOn }, 'Unknown')
+    ];
+    return this.failures;
+  }
 }
 
 const jobCache = new Cache();
@@ -353,10 +369,16 @@ class CommitBuild extends TestBuild {
     }
 
     const { result, builds } = this.getBuilds(data);
-    if (result === SUCCESS || !builds.failed.length) {
+
+    if (result !== FAILURE) {
       return { result, builds, failures: [] };
     }
 
+    if (!builds.failed.length) {
+      const failures = await this.parseConsoleText();
+      return { result, builds, failures };
+    }
+
     cli.startSpinner(`Querying failures of ${path}`);
     const promises = builds.failed.map(({jobName, buildNumber, url}) => {
       if (jobName.includes('fanned')) {
@@ -496,7 +518,13 @@ class FannedBuild extends Job {
       ];
       return this.failures;
     }
+
     const failedPhase = data.subBuilds.find(build => build.result === FAILURE);
+
+    if (!failedPhase) {
+      return this.parseConsoleText();
+    }
+
     if (failedPhase.phaseName !== TEST_PHASE &&
         !failedPhase.phaseName.toLowerCase().includes('compilation')) {
       this.failures = [
@@ -528,20 +556,8 @@ class LinterBuild extends Job {
 
   async getResults() {
     const data = await this.getAPIData();
-    const builtOn = this.builtOn = data.builtOn;
-    const text = await this.getConsoleText();
-    const parser = new CIFailureParser(this, text);
-    const results = parser.parse();
-    // TODO: add linter failure type
-    if (results) {
-      this.failures = results;
-      return results;
-    }
-
-    this.failures = [
-      new CIResult({ url: this.jobUrl, builtOn }, 'Unknown')
-    ];
-    return this.failures;
+    this.builtOn = data.builtOn;
+    return this.parseConsoleText();
   }
 }
 
@@ -565,7 +581,7 @@ class NormalBuild extends Job {
       return this.failures;
     }
 
-    if (result === FAILURE && !(runs.length)) {
+    if (!runs.length) {
       this.failures = [
         new BuildFailure(
           { url: this.jobUrl, builtOn }, 'Failed to trigger runs'
@@ -575,6 +591,11 @@ class NormalBuild extends Job {
     }
 
     const failed = runs.filter(run => run.result === FAILURE);
+
+    if (!failed.length) {
+      return this.parseConsoleText();
+    }
+
     const tests = failed.map(({ url }) => new TestRun(cli, request, url));
 
     // Skip runs that are not actually triggered by this job
@@ -618,18 +639,7 @@ class TestRun extends Job {
   }
 
   async getResults() {
-    const text = await this.getConsoleText();
-    const parser = new CIFailureParser(this, text);
-    const results = parser.parse();
-    if (results) {
-      this.failures = results;
-      return results;
-    }
-
-    this.failures = [
-      new CIResult({ url: this.jobUrl, builtOn: this.builtOn }, 'Unknown')
-    ];
-    return this.failures;
+    return this.parseConsoleText();
   }
 }