Skip to content

Commit 2f923b7

Browse files
committed
Test Windows on Python 3.14, not 3.13
1 parent c7c678f commit 2f923b7

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

.github/workflows/tests.yml

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -93,22 +93,18 @@ jobs:
9393
fail-fast: false
9494
max-parallel: 11
9595
matrix:
96-
# Windows on Python 3.14 is blocked by nodejs/node#59983
97-
os: [macos-latest, ubuntu-latest]
96+
os: [macos-latest, ubuntu-latest, windows-latest]
9897
python: ["3.10", "3.12", "3.14"]
9998
node: [20.x, 22.x, 24.x]
10099
include:
101-
- os: windows-latest
102-
python: "3.13" # Windows on Python 3.13 instead of 3.14
103-
node: 24.x
104100
- os: macos-15-intel # macOS on Intel
105101
python: "3.14"
106102
node: 24.x
107103
- os: ubuntu-24.04-arm # Ubuntu on ARM
108104
python: "3.14"
109105
node: 24.x
110106
- os: windows-11-arm # Windows on ARM
111-
python: "3.13" # Windows on Python 3.13 instead of 3.14
107+
python: "3.14"
112108
node: 24.x
113109
name: ${{ matrix.os }} - ${{ matrix.python }} - ${{ matrix.node }}
114110
runs-on: ${{ matrix.os }}
@@ -128,8 +124,6 @@ jobs:
128124
with:
129125
python-version: ${{ matrix.python }}
130126
allow-prereleases: true
131-
env:
132-
PYTHON_VERSION: ${{ matrix.python }} # Why do this?
133127
- uses: seanmiddleditch/gha-setup-ninja@v6
134128
- name: Install wasi-sdk (Windows)
135129
shell: pwsh
@@ -180,4 +174,4 @@ jobs:
180174
shell: bash # Building wasm on Windows requires using make generator, it only works in bash
181175
run: npm run test --python="${pythonLocation}\\python.exe"
182176
env:
183-
FULL_TEST: ${{ (matrix.node == '24.x' && matrix.python == '3.13') && '1' || '0' }}
177+
FULL_TEST: ${{ (matrix.node == '24.x' && matrix.python == '3.14') && '1' || '0' }}

0 commit comments

Comments
 (0)