test, lib: fix spelling errors, minor changes

swap args and name in find-python. reason in comment

add ".js" to couple imports due to import errors

Author: owl-from-hogvarts

lib/find-python.js

@@ -64,7 +64,7 @@ function colorizeOutput (color, string) {
   return color + string + RESET
 }
 
-//! on windows debug running with locale cmd (e. g. chcp 866) encoding
+//! on windows debug running with locale cmd encoding (e. g. chcp 866)
 // to avoid that uncomment next lines
 // locale encodings cause issues. See run func for more info
 // this lines only for testing
@@ -312,7 +312,8 @@ class PythonFinder {
         this.log.verbose(
           `executing "${colorizeOutput(
             GREEN,
-            check.name || check.arg
+            // DONE: swap in favor of arg (user want to see what we actually will run not how it is named)
+            check.arg || check.name
           )}" to get Python executable path`
         )
 
@@ -469,6 +470,7 @@ class PythonFinder {
           `${colorizeOutput(GREEN, 'execFile')}: args = %j`,
           args
         )
+        // TODO: make beauty print of PATH property (new line by semicolon)
         this.log.silly('execFile: opts = ', JSON.stringify(opts, null, 2))
 
         //* possible outcomes with error messages on Windows (err.message, error.stack?, stderr)
@@ -504,6 +506,7 @@ class PythonFinder {
             `${colorizeOutput(RED, 'execFile result')}: err =`,
             (err && err.stack) || err
           )
+          // TODO: add silly logs as in previous version
 
           // executed script shouldn't pass anything to stderr if successful
           if (err || stderr) {
@@ -645,8 +648,8 @@ function findPython (configPython, callback) {
 /* findPython(null, (err, found) => {
   console.log('found:', '\x1b[31m', found)
   console.log('\x1b[0m')
-})
- */
+}) 
+*/
 module.exports = findPython
 module.exports.test = {
   PythonFinder: PythonFinder,

test/test-configure-python.js

@@ -5,7 +5,7 @@ const path = require('path')
 const devDir = require('./common').devDir()
 const gyp = require('../lib/node-gyp')
 const requireInject = require('require-inject')
-const configure = requireInject('../lib/configure', {
+const configure = requireInject('../lib/configure.js', {
   'graceful-fs': {
     openSync: function () { return 0 },
     closeSync: function () { },

test/test-find-accessible-sync.js

@@ -3,7 +3,7 @@
 const test = require('tap').test
 const path = require('path')
 const requireInject = require('require-inject')
-const configure = requireInject('../lib/configure', {
+const configure = requireInject('../lib/configure.js', {
   'graceful-fs': {
     closeSync: function () { return undefined },
     openSync: function (path) {

test/test-find-python.js

@@ -95,7 +95,7 @@ test('new-find-python', { buffered: true }, (t) => {
       const pythonFinderInstance = new PythonFinder(null, (err, path) => {
         if (err) {
           t.fail(
-            `musn't produce any errors if execFile doesn't produced error. ${err}`
+            `mustn't produce any errors if execFile doesn't produced error. ${err}`
           )
         } else {
           t.strictEqual(path, testString)