fix: build.js remove comments issue

diegozhu · lukekarrys · commit 7033e6a98bab · 2023-10-27T17:08:49.000-07:00
some user may use git Windows-style line-ending which will result in JSON.parse error.
diff --git a/lib/build.js b/lib/build.js
@@ -52,7 +52,7 @@ async function build (gyp, argv) {
       }
     }
 
-    config = JSON.parse(data.replace(/#.+\n/, ''))
+    config = JSON.parse(data.replace(/#.+\r?\n/, ''))
 
     // get the 'arch', 'buildType', and 'nodeDir' vars from the config
     buildType = config.target_defaults.default_configuration

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ async function build (gyp, argv) {`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`
`55`		`- config = JSON.parse(data.replace(/#.+\n/, ''))`
	`55`	`+ config = JSON.parse(data.replace(/#.+\r?\n/, ''))`
`56`	`56`
`57`	`57`	`// get the 'arch', 'buildType', and 'nodeDir' vars from the config`
`58`	`58`	`buildType = config.target_defaults.default_configuration`