From fc480dde6e9c08d0e2da3c9e67673b3009597ad0 Mon Sep 17 00:00:00 2001 From: Dave Jeffery Date: Thu, 25 Nov 2021 10:41:41 +0000 Subject: [PATCH 1/2] fix: failure when build directory contains spaces (#65) --- gyp/pylib/gyp/generator/make.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gyp/pylib/gyp/generator/make.py b/gyp/pylib/gyp/generator/make.py index c595f20fe2..c9976e4be8 100644 --- a/gyp/pylib/gyp/generator/make.py +++ b/gyp/pylib/gyp/generator/make.py @@ -1328,7 +1328,7 @@ def WriteSources( includes = config.get("include_dirs") if includes: includes = [Sourceify(self.Absolutify(i)) for i in includes] - self.WriteList(includes, "INCS_%s" % configname, prefix="-I") + self.WriteList(includes, "INCS_%s" % configname, prefix="-I", quoter=EscapeShellArgument) compilable = list(filter(Compilable, sources)) objs = [self.Objectify(self.Absolutify(Target(c))) for c in compilable] From 8c37998a117e0cbfaeab69478e4aacc57b27d58d Mon Sep 17 00:00:00 2001 From: Dave Jeffery Date: Thu, 25 Nov 2021 12:04:34 +0000 Subject: [PATCH 2/2] fix: python lint --- gyp/pylib/gyp/generator/make.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gyp/pylib/gyp/generator/make.py b/gyp/pylib/gyp/generator/make.py index c9976e4be8..69aecad75f 100644 --- a/gyp/pylib/gyp/generator/make.py +++ b/gyp/pylib/gyp/generator/make.py @@ -1328,7 +1328,12 @@ def WriteSources( includes = config.get("include_dirs") if includes: includes = [Sourceify(self.Absolutify(i)) for i in includes] - self.WriteList(includes, "INCS_%s" % configname, prefix="-I", quoter=EscapeShellArgument) + self.WriteList( + includes, + "INCS_%s" % configname, + prefix="-I", + quoter=EscapeShellArgument + ) compilable = list(filter(Compilable, sources)) objs = [self.Objectify(self.Absolutify(Target(c))) for c in compilable]