From 91eb407f8418235d51c72b6a8df9c454ba882554 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Mon, 7 Mar 2022 16:31:46 +0100 Subject: [PATCH 1/4] Update README.md --- docs/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/README.md b/docs/README.md index 1bec1f0d57..7027960909 100644 --- a/docs/README.md +++ b/docs/README.md @@ -1,4 +1,4 @@ -## Versions of `node-gyp` that are earlier than v8.x.x +## Versions of `node-gyp` that are earlier than v9.x.x Please look thru your error log for the string `gyp info using node-gyp@` and if that version number is less than the [current release of node-gyp](https://github.com/nodejs/node-gyp/releases) then __please upgrade__ using [these instructions](https://github.com/nodejs/node-gyp/blob/master/docs/Updating-npm-bundled-node-gyp.md) and then try your command again. From 1206a82683697a89e070e4a5d4b7a83b6ef0ea32 Mon Sep 17 00:00:00 2001 From: Doni Rubiagatra Date: Tue, 3 May 2022 15:52:28 +0700 Subject: [PATCH 2/4] fix: typo on readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index d28a0cc9ef..48bf763943 100644 --- a/README.md +++ b/README.md @@ -89,7 +89,7 @@ searching will be done. ### Build for Third Party Node.js Runtimes -When building modules for thid party Node.js runtimes like Electron, which have +When building modules for third party Node.js runtimes like Electron, which have different build configurations from the official Node.js distribution, you should use `--dist-url` or `--nodedir` flags to specify the headers of the runtime to build for. From a37f186eacc17145e00972262d91e6402404ce05 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Sun, 8 May 2022 11:40:43 +0200 Subject: [PATCH 3/4] GitHub Actions: Add Node.js 18 and drop 12 Node.js 12 is end-of-life. https://nodejs.org/en/about/releases Python 3.6 is end-of-life. https://devguide.python.org/#status-of-python-branches --- .github/workflows/tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 83ccf7f547..a2c899a71f 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -8,13 +8,13 @@ jobs: fail-fast: false max-parallel: 15 matrix: - node: [12.x, 14.x, 16.x] - python: ["3.6", "3.8", "3.10"] + node: [14.x, 16.x, 18.x] + python: ["3.7", "3.8", "3.10"] os: [macos-latest, ubuntu-latest, windows-latest] runs-on: ${{ matrix.os }} steps: - name: Checkout Repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Use Node.js ${{ matrix.node }} uses: actions/setup-node@v3 with: From bd8fe9cf29bd996156f6c8029c408c76bf1a2587 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Tue, 10 May 2022 13:54:37 +0200 Subject: [PATCH 4/4] gyp should use Python 3 not Python --- gyp/gyp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gyp/gyp b/gyp/gyp index 1b8b9bdfb0..8c9359fef0 100755 --- a/gyp/gyp +++ b/gyp/gyp @@ -5,4 +5,4 @@ set -e base=$(dirname "$0") -exec python "${base}/gyp_main.py" "$@" +exec python3 "${base}/gyp_main.py" "$@"