feat: clearBreakpoint

Author: Jan Krems

lib/internal/inspect-repl.js

@@ -34,7 +34,7 @@ const SHORTCUTS = {
   out: 'o',
   backtrace: 'bt',
   setBreakpoint: 'sb',
-  // clearBreakpoint: 'cb',
+  clearBreakpoint: 'cb',
   // pause_: 'pause',
   // run: 'r',
 };
@@ -488,6 +488,24 @@ function createRepl(inspector) {
       });
   }
 
+  function clearBreakpoint(url, line) {
+    const breakpoint = knownBreakpoints.find(({ location }) => {
+      if (!location) return false;
+      const script = knownScripts[location.scriptId];
+      if (!script) return false;
+      return script.url.indexOf(url) !== -1 && (location.lineNumber + 1) === line;
+    });
+    if (!breakpoint) {
+      print(`Could not find breakpoint at ${url}:${line}`);
+      return Promise.resolve();
+    }
+    return Debugger.removeBreakpoint({ breakpointId: breakpoint.breakpointId })
+      .then(() => {
+        const idx = knownBreakpoints.indexOf(breakpoint);
+        knownBreakpoints.splice(idx, 1);
+      });
+  }
+
   Debugger.on('paused', ({ callFrames, reason /* , hitBreakpoints */ }) => {
     // Save execution context's data
     currentBacktrace = Backtrace.from(callFrames);
@@ -567,6 +585,7 @@ function createRepl(inspector) {
 
       scripts: listScripts,
       setBreakpoint,
+      clearBreakpoint,
       list,
     });
     aliasProperties(context, SHORTCUTS);

test/cli/break.test.js

@@ -116,3 +116,42 @@ test('sb before loading file', (t) => {
     .then(() => cli.quit())
     .then(null, onFatal);
 });
+
+test('clearBreakpoint', (t) => {
+  const cli = startCLI(['examples/break.js']);
+
+  function onFatal(error) {
+    cli.quit();
+    throw error;
+  }
+
+  return cli.waitFor(/break/)
+    .then(() => cli.waitForPrompt())
+    .then(() => cli.command('sb("break.js", 3)'))
+    .then(() => cli.command('sb("break.js", 9)'))
+    .then(() => cli.command('breakpoints'))
+    .then(() => {
+      t.match(cli.output, '#0 examples/break.js:3');
+      t.match(cli.output, '#1 examples/break.js:9');
+    })
+    .then(() => cli.command('clearBreakpoint("break.js", 4)'))
+    .then(() => {
+      t.match(cli.output, 'Could not find breakpoint');
+    })
+    .then(() => cli.command('clearBreakpoint("not-such-script.js", 3)'))
+    .then(() => {
+      t.match(cli.output, 'Could not find breakpoint');
+    })
+    .then(() => cli.command('clearBreakpoint("break.js", 3)'))
+    .then(() => cli.command('breakpoints'))
+    .then(() => {
+      t.match(cli.output, '#0 examples/break.js:9');
+    })
+    .then(() => cli.stepCommand('cont'))
+    .then(() => {
+      t.match(cli.output, 'break in examples/break.js:9',
+        'hits the 2nd breakpoint because the 1st was cleared');
+    })
+    .then(() => cli.quit())
+    .then(null, onFatal);
+});