feat: Add remaining sb() variants

Author: Jan Krems

examples/myscript.js

@@ -2,9 +2,10 @@
 'use strict';
 console.log('initial thing');
 debugger;
-const x = process.argv[2] || 'world';
+const strings = require('./strings.js');
+const x = process.argv[2] || strings.world;
 setInterval(() => {
   // debugger;
   console.log(x);
 }, 1000);
-console.log('hello');
+console.log(strings.hello);

examples/strings.js

@@ -0,0 +1,5 @@
+/* eslint no-restricted-syntax: 0, no-debugger: 0 */
+'use strict';
+exports.hello = 'Hello';
+debugger;
+exports.world = 'World';

lib/node-inspect.js

@@ -479,6 +479,9 @@ function createCommandContext(inspector) {
 
   const knownBreakpoints = new Map();
 
+  const writer = createRemoteAwareWriter(true);
+  const formatValue = value => writer(value);
+
   // Clear current line
   function clearline() {
     if (stdout.isTTY) {
@@ -569,26 +572,83 @@ function createCommandContext(inspector) {
     },
 
     setBreakpoint(script, line, condition, silent) {
-      const registerBreakpoint = ({ breakpointId, actualLocation }) => {
-        knownBreakpoints.set(breakpointId, actualLocation);
-      };
+      function registerBreakpoint({ breakpointId, actualLocation }) {
+        if (actualLocation) {
+          knownBreakpoints.set(breakpointId, actualLocation);
+          if (!silent) return ctx.list(5);
+        } else {
+          print(`Warning: script '${script}' was not loaded yet.`);
+        }
+        return undefined;
+      }
 
-      // setBreakpoint()
+      // setBreakpoint(): set breakpoint at current location
       if (script === undefined) {
-        // set breakpoint at current location
+        // TODO: assertIsPaused()
         return Debugger.setBreakpoint({ location: currentSourceLocation, condition })
           .then(registerBreakpoint);
       }
 
-      // setBreakpoint(line)
+      // setBreakpoint(line): set breakpoint in current script at specific line
       if (line === undefined && typeof script === 'number') {
+        // TODO: assertIsPaused()
         const location = Object.assign({}, currentSourceLocation, {
           lineNumber: script - 1,
         });
         return Debugger.setBreakpoint({ location, condition })
           .then(registerBreakpoint);
       }
-      throw new Error('Not implemented');
+
+      if (typeof script !== 'string') {
+        throw new TypeError(`setBreakpoint() expects a string, got ${script}`);
+      }
+
+      // setBreakpoint('fn()'): Break when a function is called
+      if (script.endsWith('()')) {
+        // TODO: handle !currentFrame (~Runtime.evaluate)
+        return Debugger.evaluateOnCallFrame({
+          callFrameId: currentFrame,
+          expression: `debug(${script.slice(0, -2)})`,
+          includeCommandLineAPI: true,
+        }).then(() => undefined); // hide the noise
+      }
+
+      // setBreakpoint('scriptname')
+      let scriptId = null;
+      let ambiguous = false;
+      if (scripts[script]) {
+        scriptId = script;
+      } else {
+        for (const id of Object.keys(scripts)) {
+          if (scripts[id] && scripts[id].url && scripts[id].url.indexOf(script) !== -1) {
+            if (scriptId !== null) {
+              ambiguous = true;
+            }
+            scriptId = id;
+          }
+        }
+      }
+
+      if (ambiguous) {
+        print('Script name is ambiguous');
+        return undefined;
+      }
+      if (line <= 0) {
+        print('Line should be a positive value');
+        return undefined;
+      }
+
+      if (scriptId !== null) {
+        const location = { scriptId, lineNumber: line - 1 };
+        return Debugger.setBreakpoint({ location, condition })
+          .then(registerBreakpoint);
+      }
+
+      const escapedPath = script.replace(/([/\\.?*()^${}|[\]])/g, '\\$1');
+      const urlRegex = `^(.*[\\/\\\\])?${escapedPath}$`;
+
+      return Debugger.setBreakpointByUrl({ urlRegex, lineNumber: line - 1, condition })
+        .then(registerBreakpoint);
     },
 
     get cont() {
@@ -678,9 +738,6 @@ function createCommandContext(inspector) {
         return Promise.resolve();
       }
 
-      const writer = createRemoteAwareWriter(true);
-      const formatValue = value => writer(value);
-
       const inspectValue = expr =>
         ctx.debugEval(expr)
           .then(formatValue)
@@ -729,6 +786,8 @@ function createCommandContext(inspector) {
       .then(() => repl.displayPrompt());
   });
 
+  // TODO: Debugger.on('breakpointResolved', ({ })
+
   Debugger.on('scriptParsed', ({ scriptId, url }) => {
     if (url) {
       scripts[scriptId] = { url };