feat: Add breakpoints command

Author: Jan Krems

lib/node-inspect.js

@@ -588,8 +588,8 @@ function createCommandContext(inspector) {
 
     setBreakpoint(script, line, condition, silent) {
       function registerBreakpoint({ breakpointId, actualLocation }) {
-        if (actualLocation) {
-          handleBreakpointResolved({ breakpointId, location: actualLocation });
+        handleBreakpointResolved({ breakpointId, location: actualLocation });
+        if (actualLocation && actualLocation.scriptId) {
           if (!silent) return ctx.list(5);
         } else {
           print(`Warning: script '${script}' was not loaded yet.`);
@@ -666,14 +666,32 @@ function createCommandContext(inspector) {
       const urlRegex = `^(.*[\\/\\\\])?${escapedPath}$`;
 
       return Debugger.setBreakpointByUrl({ urlRegex, lineNumber: line - 1, condition })
-        .then(registerBreakpoint);
+        .then(bp => {
+          // TODO: handle bp.locations in case the regex matches existing files
+          if (!bp.location) { // Fake it for now.
+            bp.actualLocation = { scriptUrl: `.*/${script}$`, lineNumber: line - 1 };
+          }
+          return registerBreakpoint(bp);
+        });
     },
 
     clearBreakpoint() {
       // TODO: Use Debugger.removeBreakpoint({ breakpointId })
       throw new Error('Not implemented');
     },
 
+    get breakpoints() {
+      function formatLocation(location) {
+        if (!location) return '<unknown location>';
+        const script = scripts[location.scriptId];
+        const scriptUrl = script ? script.url : location.scriptUrl;
+        return `${getRelativePath(scriptUrl)}:${location.lineNumber}`;
+      }
+      knownBreakpoints.forEach((bp, idx) => {
+        print(`#${idx} ${formatLocation(bp.location)}`);
+      });
+    },
+
     get cont() {
       return Debugger.resume();
     },
@@ -723,7 +741,7 @@ function createCommandContext(inspector) {
 
             let isBreakpoint = false;
             knownBreakpoints.forEach(({ location }) => {
-              if (location.scriptId === scriptId && (location.lineNumber + 1) === i) {
+              if (location && location.scriptId === scriptId && (location.lineNumber + 1) === i) {
                 isBreakpoint = true;
               }
             });