feat: Add setBreakpoint(line)

Author: Jan Krems

lib/node-inspect.js

@@ -325,6 +325,13 @@ function toCallback(promise, callback) {
     .then(callback.bind(null, null), callback);
 }
 
+function unpackError({ code, message, data }) {
+  const err = new Error(`${message} - ${data}`);
+  err.code = code;
+  Error.captureStackTrace(err, unpackError);
+  return err;
+}
+
 class Client extends events.EventEmitter {
   constructor() {
     super();
@@ -374,7 +381,7 @@ class Client extends events.EventEmitter {
     return new Promise((resolve, reject) => {
       const data = { id: ++this._lastId, method, params };
       this._pending[data.id] = (error, result) => {
-        if (error) reject(error);
+        if (error) reject(unpackError(error));
         else resolve(isEmpty(result) ? undefined : result);
       };
       const json = JSON.stringify(data);
@@ -470,7 +477,7 @@ function createCommandContext(inspector) {
   const scripts = {};
   const watchedExpressions = [];
 
-  const breakPoints = new Map();
+  const knownBreakpoints = new Map();
 
   // Clear current line
   function clearline() {
@@ -529,7 +536,7 @@ function createCommandContext(inspector) {
 
     setBreakpoint(script, line, condition, silent) {
       const registerBreakpoint = ({ breakpointId, actualLocation }) => {
-        breakPoints.set(breakpointId, actualLocation);
+        knownBreakpoints.set(breakpointId, actualLocation);
       };
 
       // setBreakpoint()
@@ -538,6 +545,15 @@ function createCommandContext(inspector) {
         return Debugger.setBreakpoint({ location: currentSourceLocation, condition })
           .then(registerBreakpoint);
       }
+
+      // setBreakpoint(line)
+      if (line === undefined && typeof script === 'number') {
+        const location = Object.assign({}, currentSourceLocation, {
+          lineNumber: script - 1,
+        });
+        return Debugger.setBreakpoint({ location, condition })
+          .then(registerBreakpoint);
+      }
       throw new Error('Not implemented');
     },
 
@@ -589,7 +605,7 @@ function createCommandContext(inspector) {
             }
 
             let isBreakpoint = false;
-            breakPoints.forEach(actualLocation => {
+            knownBreakpoints.forEach(actualLocation => {
               if (actualLocation.scriptId === scriptId && (actualLocation.lineNumber + 1) === i) {
                 isBreakpoint = true;
               }