util: limit inspect to only show own properties

Error's cause and errors properties would be visible even if these
were not own properties. This is changed to align with all other
parts of the inspect handling.

As drive-by I changed an array to a set for faster lookup in assert.

Fixes: #60717
Closes: #60724

Author: BridgeAR

lib/internal/assert/assertion_error.js

@@ -42,7 +42,7 @@ const kReadableOperator = {
 const kMaxShortStringLength = 12;
 const kMaxLongStringLength = 512;
 
-const kMethodsWithCustomMessageDiff = ['deepStrictEqual', 'strictEqual', 'partialDeepStrictEqual'];
+const kMethodsWithCustomMessageDiff = new Set(['deepStrictEqual', 'strictEqual', 'partialDeepStrictEqual']);
 
 function copyError(source) {
   const target = ObjectAssign(
@@ -263,7 +263,7 @@ class AssertionError extends Error {
     if (isErrorStackTraceLimitWritable()) Error.stackTraceLimit = 0;
 
     if (message != null) {
-      if (kMethodsWithCustomMessageDiff.includes(operator)) {
+      if (kMethodsWithCustomMessageDiff.has(operator)) {
         super(createErrDiff(actual, expected, operator, message, diff));
       } else {
         super(String(message));
@@ -283,7 +283,7 @@ class AssertionError extends Error {
         expected = copyError(expected);
       }
 
-      if (kMethodsWithCustomMessageDiff.includes(operator)) {
+      if (kMethodsWithCustomMessageDiff.has(operator)) {
         super(createErrDiff(actual, expected, operator, message, diff));
       } else if (operator === 'notDeepStrictEqual' ||
         operator === 'notStrictEqual') {

lib/internal/util/inspect.js

@@ -1955,15 +1955,15 @@ function formatError(err, constructor, tag, ctx, keys) {
   }
   name ??= 'Error';
 
-  if ('cause' in err &&
+  if (ObjectPrototypeHasOwnProperty(err, 'cause') &&
       (keys.length === 0 || !ArrayPrototypeIncludes(keys, 'cause'))) {
     ArrayPrototypePush(keys, 'cause');
   }
 
   // Print errors aggregated into AggregateError
   try {
     const errors = err.errors;
-    if (ArrayIsArray(errors) &&
+    if (ArrayIsArray(errors) && ObjectPrototypeHasOwnProperty(err, 'errors') &&
       (keys.length === 0 || !ArrayPrototypeIncludes(keys, 'errors'))) {
       ArrayPrototypePush(keys, 'errors');
     }

test/parallel/test-util-inspect.js

@@ -688,6 +688,53 @@ assert.strictEqual(util.inspect(-5e-324), '-5e-324');
   );
 }
 
+{
+  // No own errors or cause property.
+  const { stackTraceLimit } = Error;
+  Error.stackTraceLimit = 0;
+
+  const e1 = new Error('e1');
+  const e2 = new TypeError('e2');
+  const e3 = false;
+
+  const errors = [e1, e2, e3];
+  const aggregateError = new AggregateError(errors, 'Foobar');
+
+  assert.deepStrictEqual(aggregateError.errors, errors);
+  assert.strictEqual(
+    util.inspect(aggregateError),
+    '[AggregateError: Foobar] {\n  [errors]: [ [Error: e1], [TypeError: e2], false ]\n}'
+  );
+
+
+  const custom = new Error('No own errors property');
+  Object.setPrototypeOf(custom, aggregateError);
+
+  assert.strictEqual(
+    util.inspect(custom),
+    '[AggregateError: No own errors property]'
+  );
+
+  const cause = [new Error('cause')];
+  const causeError = new TypeError('Foobar', { cause: [new Error('cause')] });
+
+  assert.strictEqual(
+    util.inspect(causeError),
+    '[TypeError: Foobar] { [cause]: [ [Error: cause] ] }'
+  );
+
+  const custom2 = new Error('No own cause property');
+  Object.setPrototypeOf(custom2, causeError);
+
+  assert.deepStrictEqual(custom2.cause, cause);
+  assert.strictEqual(
+    util.inspect(custom2),
+    '[TypeError: No own cause property]'
+  );
+
+  Error.stackTraceLimit = stackTraceLimit;
+}
+
 {
   const tmp = Error.stackTraceLimit;
   // Force stackTraceLimit = 0 for this test, but make it non-enumerable