esm: tidy tests

Author: JakobJingleheimer

test/common/index.mjs

@@ -23,6 +23,7 @@ const {
   hasCrypto,
   hasIPv6,
   childShouldThrowAndAbort,
+  checkoutEOL,
   createZeroFilledFile,
   platformTimeout,
   allowGlobals,
@@ -70,6 +71,7 @@ export {
   hasCrypto,
   hasIPv6,
   childShouldThrowAndAbort,
+  checkoutEOL,
   createZeroFilledFile,
   platformTimeout,
   allowGlobals,

test/es-module/helper.spawnAsPromised.mjs

@@ -0,0 +1,32 @@
+import cp from 'node:child_process';
+
+
+export default function spawn(...args) {
+  let stderr = '';
+  let stdout = '';
+
+  const child = cp.spawn(...args);
+  child.stderr.setEncoding('utf8');
+  child.stderr.on('data', (data) => { stderr += data; });
+  child.stdout.setEncoding('utf8');
+  child.stdout.on('data', (data) => { stdout += data; });
+
+  return new Promise((resolve, reject) => {
+    child.on('close', (code, signal) => {
+      resolve({
+        code,
+        signal,
+        stderr,
+        stdout,
+      });
+    });
+    child.on('error', (code, signal) => {
+      reject({
+        code,
+        signal,
+        stderr,
+        stdout,
+      });
+    });
+  });
+}

test/es-module/test-cjs-esm-warn.js

@@ -0,0 +1,65 @@
+import { mustCall } from '../common/index.mjs';
+import * as fixtures from '../common/fixtures.mjs';
+import assert from 'node:assert';
+import path from 'node:path';
+import { execPath } from 'node:process';
+
+import spawn from './helper.spawnAsPromised.mjs';
+
+
+const requiringCjsAsEsm = path.resolve(fixtures.path('/es-modules/cjs-esm.js'));
+const requiringEsm = path.resolve(fixtures.path('/es-modules/cjs-esm-esm.js'));
+const pjson = path.resolve(
+  fixtures.path('/es-modules/package-type-module/package.json')
+);
+
+{
+  const required = path.resolve(
+    fixtures.path('/es-modules/package-type-module/cjs.js')
+  );
+  const basename = 'cjs.js';
+  spawn(execPath, [requiringCjsAsEsm])
+    .then(mustCall(({ code, signal, stderr }) => {
+      assert.ok(
+        stderr.replaceAll('\r', '').includes(
+          `Error [ERR_REQUIRE_ESM]: require() of ES Module ${required} from ${requiringCjsAsEsm} not supported.\n`
+        )
+      );
+      assert.ok(
+        stderr.replaceAll('\r', '').includes(
+          `Instead rename ${basename} to end in .cjs, change the requiring ` +
+          'code to use dynamic import() which is available in all CommonJS ' +
+          `modules, or change "type": "module" to "type": "commonjs" in ${pjson} to ` +
+          'treat all .js files as CommonJS (using .mjs for all ES modules ' +
+          'instead).\n'
+        )
+      );
+
+      assert.strictEqual(code, 1);
+      assert.strictEqual(signal, null);
+    }));
+}
+
+{
+  const required = path.resolve(
+    fixtures.path('/es-modules/package-type-module/esm.js')
+  );
+  const basename = 'esm.js';
+  spawn(execPath, [requiringEsm])
+    .then(mustCall(({ code, signal, stderr }) => {
+      assert.ok(
+        stderr.replace(/\r/g, '').includes(
+          `Error [ERR_REQUIRE_ESM]: require() of ES Module ${required} from ${requiringEsm} not supported.\n`
+        )
+      );
+      assert.ok(
+        stderr.replace(/\r/g, '').includes(
+          `Instead change the require of ${basename} in ${requiringEsm} to` +
+          ' a dynamic import() which is available in all CommonJS modules.\n'
+        )
+      );
+
+      assert.strictEqual(code, 1);
+      assert.strictEqual(signal, null);
+    }));
+}

test/es-module/test-cjs-esm-warn.mjs

@@ -0,0 +1,15 @@
+import { mustCall } from '../common/index.mjs';
+import * as fixtures from '../common/fixtures.mjs';
+import assert from 'node:assert';
+import { execPath } from 'node:process';
+
+import spawn from './helper.spawnAsPromised.mjs';
+
+const entry = fixtures.path('/es-modules/builtin-imports-case.mjs');
+
+spawn(execPath, [entry])
+  .then(mustCall(({ code, signal, stdout }) => {
+    assert.strictEqual(code, 0);
+    assert.strictEqual(signal, null);
+    assert.strictEqual(stdout, 'ok\n');
+  }));

test/es-module/test-esm-cjs-builtins.js

@@ -0,0 +1,24 @@
+import { mustCall } from '../common/index.mjs';
+import * as fixtures from '../common/fixtures.mjs';
+import assert from 'node:assert';
+import { execPath } from 'node:process';
+
+import spawn from './helper.spawnAsPromised.mjs';
+
+
+const validEntry = fixtures.path('/es-modules/cjs-exports.mjs');
+spawn(execPath, [validEntry])
+  .then(mustCall(({ code, signal, stdout }) => {
+    assert.strictEqual(code, 0);
+    assert.strictEqual(signal, null);
+    assert.strictEqual(stdout, 'ok\n');
+  }));
+
+const invalidEntry = fixtures.path('/es-modules/cjs-exports-invalid.mjs');
+spawn(execPath, [invalidEntry])
+  .then(mustCall(({ code, signal, stderr }) => {
+    assert.strictEqual(code, 1);
+    assert.strictEqual(signal, null);
+    assert.ok(stderr.includes('Warning: To load an ES module'));
+    assert.ok(stderr.includes('Unexpected token \'export\''));
+  }));