Skip to content

Commit 05b02d7

Browse files
committed
Revert "test: disable fast API call count checks"
This reverts commit 6857dbc.
1 parent e9aaec4 commit 05b02d7

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

test/parallel/test-buffer-write-fast.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,5 @@ testFastUtf8Write();
4141

4242
if (common.isDebug) {
4343
const { getV8FastApiCallCount } = internalBinding('debug');
44-
// TODO: the count should be 4. The function is optimized, but the fast
45-
// API is not called.
46-
assert.strictEqual(getV8FastApiCallCount('buffer.writeString'), 0);
44+
assert(getV8FastApiCallCount('buffer.writeString'), 4);
4745
}

test/parallel/test-whatwg-url-canparse.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,7 @@ assert.strictEqual(URL.canParse('https://example.org'), true);
3434

3535
if (common.isDebug) {
3636
const { getV8FastApiCallCount } = internalBinding('debug');
37-
// TODO: the counts should be 1. The function is optimized, but the fast
38-
// API is not called.
39-
assert.strictEqual(getV8FastApiCallCount('url.canParse'), 0);
40-
assert.strictEqual(getV8FastApiCallCount('url.canParse.withBase'), 0);
37+
assert.strictEqual(getV8FastApiCallCount('url.canParse'), 1);
38+
assert.strictEqual(getV8FastApiCallCount('url.canParse.withBase'), 1);
4139
}
4240
}

0 commit comments

Comments
 (0)