Skip to content

Commit 05f8772

Browse files
authored
tools: fix update-nghttp2 signature verification
Detached signatures must be passed to `gpgv` as a filename before the datafile (which can be stdin but the detached signature file cannot be stdin and cannot be piped in). PR-URL: #61035 Refs: #60113 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 6322071 commit 05f8772

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

tools/dep_updaters/update-nghttp2.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,13 @@ echo "Fetching nghttp2 source archive"
5050
curl -sL -o "$NGHTTP2_TARBALL" "https://github.com/nghttp2/nghttp2/releases/download/$NGHTTP2_REF/$NGHTTP2_TARBALL"
5151

5252
echo "Verifying PGP signature"
53-
curl -sL "https://github.com/nghttp2/nghttp2/releases/download/${NGHTTP2_REF}/${NGHTTP2_TARBALL}.asc" \
54-
| gpgv --keyring "$BASE_DIR/tools/dep_updaters/nghttp.kbx" "$NGHTTP2_TARBALL"
53+
curl -sL -o "${NGHTTP2_TARBALL}.asc" "https://github.com/nghttp2/nghttp2/releases/download/${NGHTTP2_REF}/${NGHTTP2_TARBALL}.asc"
54+
gpgv --keyring "$BASE_DIR/tools/dep_updaters/nghttp.kbx" "${NGHTTP2_TARBALL}.asc" "${NGHTTP2_TARBALL}"
5555

5656
echo "Unpacking archive"
5757
tar xJf "$NGHTTP2_TARBALL"
5858
rm "$NGHTTP2_TARBALL"
59+
rm "${NGHTTP2_TARBALL}.asc"
5960
mv "nghttp2-$NEW_VERSION" nghttp2
6061

6162
echo "Removing everything, except lib/ and COPYING"

0 commit comments

Comments
 (0)