Skip to content

Commit 0946c8b

Browse files
authored
tools: disable nullability-completeness warnings
Seems Clang-specific and doesn't only affect macOS. This is a very noisy warning from abseil-cpp. PR-URL: #59392 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 0cb9922 commit 0946c8b

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

tools/v8_gypfiles/toolchain.gypi

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,13 +131,27 @@
131131
'xcode_settings': {
132132
# -Wno-invalid-offsetof
133133
'GCC_WARN_ABOUT_INVALID_OFFSETOF_MACRO': 'NO',
134+
},
135+
'msvs_settings': {
136+
'VCCLCompilerTool': {
137+
'AdditionalOptions': ['-Wno-invalid-offsetof'],
138+
},
139+
},
140+
}],
141+
['clang==1', {
142+
'cflags_cc': [
143+
'-Wno-nullability-completeness',
144+
],
145+
'xcode_settings': {
134146
'OTHER_CFLAGS': [
135147
'-Wno-nullability-completeness',
136148
],
137149
},
138150
'msvs_settings': {
139151
'VCCLCompilerTool': {
140-
'AdditionalOptions': ['-Wno-invalid-offsetof'],
152+
'AdditionalOptions': [
153+
'-Wno-nullability-completeness',
154+
],
141155
},
142156
},
143157
}],

0 commit comments

Comments
 (0)