Skip to content

Commit 0b75f1d

Browse files
fixup! tools: add message on auto-fixing js lint issues in gh workflow
update lint message as suggested
1 parent c50c217 commit 0b75f1d

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

.github/workflows/linters.yml

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,20 @@ jobs:
112112
echo
113113
echo 'ERROR: The JavaScript lint validation failed (the errors are logged above).'
114114
echo ' Please fix the lint errors.'
115-
echo ' Run:'
116-
echo ' make lint-js-fix'
117-
echo ' to fix the auto-fixable lint issues.'
115+
if make lint-js-fix; then
116+
echo ' Run:'
117+
echo ' make lint-js-fix'
118+
echo ' to fix the lint issues.'
119+
git diff
120+
elif git diff --quiet --exit-code; then
121+
echo ' None of the issue is auto-fixable, so manual fixed for'
122+
echo ' all of the issues are required.'
123+
else
124+
echo ' Run:'
125+
echo ' make lint-js-fix'
126+
echo ' to fix the auto-fixable lint issues'
127+
echo ' note that however some manual fixes are also required.'
128+
fi
118129
echo
119130
exit "$EXIT_CODE"
120131
fi

0 commit comments

Comments
 (0)