lib: call normalizeEncoding in fs.writeFileSync and fs.readFileSync

Author: JonasBa

benchmark/fs/bench-writeFileSync.js

@@ -7,7 +7,7 @@ tmpdir.refresh();
 
 // Some variants are commented out as they do not show a change and just slow
 const bench = common.createBenchmark(main, {
-  encoding: ['utf8'],
+  encoding: ['utf8', 'UTF8'],
   useFd: ['true', 'false'],
   length: [1024, 102400, 1024 * 1024],
 

lib/fs.js

@@ -60,6 +60,8 @@ const {
 
 const pathModule = require('path');
 const { isAbsolute } = pathModule;
+
+const { normalizeEncoding } = require('internal/util');
 const { isArrayBufferView } = require('internal/util/types');
 
 const binding = internalBinding('fs');
@@ -428,7 +430,7 @@ function tryReadSync(fd, isUserFd, buffer, pos, len) {
 function readFileSync(path, options) {
   options = getOptions(options, { flag: 'r' });
 
-  if (options.encoding === 'utf8' || options.encoding === 'utf-8') {
+  if (normalizeEncoding(options.encoding) === 'utf8') {
     if (!isInt32(path)) {
       path = getValidatedPath(path);
     }
@@ -2383,7 +2385,7 @@ function writeFileSync(path, data, options) {
   const flag = options.flag || 'w';
 
   // C++ fast path for string data and UTF8 encoding
-  if (typeof data === 'string' && (options.encoding === 'utf8' || options.encoding === 'utf-8')) {
+  if (typeof data === 'string' && normalizeEncoding(options.encoding) === 'utf8') {
     if (!isInt32(path)) {
       path = getValidatedPath(path);
     }