Skip to content

Commit 20cdbe4

Browse files
committed
fixup! benchmark: ensure integer division in http headers benchmark
1 parent f560cd7 commit 20cdbe4

File tree

1 file changed

+17
-16
lines changed

1 file changed

+17
-16
lines changed

doc/contributing/writing-and-running-benchmarks.md

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -700,14 +700,6 @@ Supported options keys are:
700700
* `benchmarker` - benchmarker to use, defaults to the first available http
701701
benchmarker
702702

703-
[autocannon]: https://github.com/mcollina/autocannon
704-
[benchmark-ci]: https://github.com/nodejs/benchmarking/blob/HEAD/docs/core_benchmarks.md
705-
[git-for-windows]: https://git-scm.com/download/win
706-
[nghttp2.org]: https://nghttp2.org
707-
[node-benchmark-compare]: https://github.com/targos/node-benchmark-compare
708-
[t-test]: https://en.wikipedia.org/wiki/Student%27s_t-test#Equal_or_unequal_sample_sizes%2C_unequal_variances_%28sX1_%3E_2sX2_or_sX2_%3E_2sX1%29
709-
[wrk]: https://github.com/wg/wrk
710-
711703
### Creating Benchmark Tests
712704

713705
It is recommended to create a new test file when a new benchmark is introduced
@@ -742,24 +734,33 @@ only a single configuration per benchmark executes.
742734
While this dramatically reduces execution time, it provides limited coverage
743735
and cannot guarantee that all configurations function properly.
744736

745-
This PR introduces the usage of a new environment variable `NODE_RUN_ALL_BENCH_TESTS`, which can be set to run all benchmark configurations in tests to cover more scenarios where benchmarks might fail.
737+
This PR introduces the usage of a new environment variable `NODE_RUN_ALL_BENCH_TESTS`,
738+
which can be set to run all benchmark configurations in tests to cover more scenarios where benchmarks might fail.
746739
This PR also documents how to write benchmark tests and provides more details about the environment variables:
747740

748-
* NODE_RUN_ALL_BENCH_TESTS
749-
* NODEJS_BENCHMARK_ZERO_ALLOWED
741+
* NODE\_RUN\_ALL\_BENCH\_TESTS
742+
* NODEJS\_BENCHMARK\_ZERO\_ALLOWED
750743

751744
Benchmark tests were added for the following groups:
752745

753-
* abort_controller
746+
* abort\_controller
754747
* error
755748
* https
756-
* perf_hooks
749+
* perf\_hooks
757750
* permission
758751
* sqlite
759-
* test_runner
752+
* test\_runner
760753
* websocket
761754

762755
Additionally, some inconsistent test files were renamed:
763756

764-
test/benchmark/test-benchmark-async-hooks.js → test/benchmark/test-benchmark-async_hooks.js
765-
test/benchmark/test-benchmark-child-process.js → test/benchmark/test-benchmark-child_process.js
757+
test/benchmark/test-benchmark-async-hooks.js → test/benchmark/test-benchmark-async\_hooks.js
758+
test/benchmark/test-benchmark-child-process.js → test/benchmark/test-benchmark-child\_process.js
759+
760+
[autocannon]: https://github.com/mcollina/autocannon
761+
[benchmark-ci]: https://github.com/nodejs/benchmarking/blob/HEAD/docs/core_benchmarks.md
762+
[git-for-windows]: https://git-scm.com/download/win
763+
[nghttp2.org]: https://nghttp2.org
764+
[node-benchmark-compare]: https://github.com/targos/node-benchmark-compare
765+
[t-test]: https://en.wikipedia.org/wiki/Student%27s_t-test#Equal_or_unequal_sample_sizes%2C_unequal_variances_%28sX1_%3E_2sX2_or_sX2_%3E_2sX1%29
766+
[wrk]: https://github.com/wg/wrk

0 commit comments

Comments
 (0)