Skip to content

Commit 24f92ec

Browse files
joyeecheungtargos
authored andcommitted
deps: V8: cherry-pick 6eff00a342cb
Original commit message: [runtime] zero-initialize descriptor array padding So that snapshot and code cache stay reproducible. See nodejs/node-v8#304 Change-Id: Ic30970097ab46a26fa5bcf0f73e0fe62089890cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7271645 Reviewed-by: Patrick Thier <[email protected]> Commit-Queue: Joyee Cheung <[email protected]> Cr-Commit-Position: refs/heads/main@{#104436} Refs: v8/v8@6eff00a
1 parent 275d956 commit 24f92ec

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.9',
41+
'v8_embedder_string': '-node.10',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/src/objects/objects.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3937,6 +3937,9 @@ void DescriptorArray::Initialize(Tagged<EnumCache> empty_enum_cache,
39373937
set_enum_cache(empty_enum_cache, SKIP_WRITE_BARRIER);
39383938
set_flags(FastIterableBits::encode(FastIterableState::kUnknown),
39393939
kRelaxedStore);
3940+
#if TAGGED_SIZE_8_BYTES
3941+
set_optional_padding(0);
3942+
#endif
39403943
MemsetTagged(GetDescriptorSlot(0), undefined_value,
39413944
number_of_all_descriptors() * kEntrySize);
39423945
}

0 commit comments

Comments
 (0)