sqlite: restrict valid authz code

Author: araujogui

src/node_sqlite.cc

@@ -1930,7 +1930,7 @@ int DatabaseSync::AuthorizerCallback(void* user_data,
 
   if (try_catch.HasCaught()) {
     // If there's an exception in the callback, deny the operation
-    // TODO: Rethrow exepction
+    // TODO: Rethrow exception
     return SQLITE_DENY;
   }
 
@@ -1939,13 +1939,19 @@ int DatabaseSync::AuthorizerCallback(void* user_data,
     return SQLITE_DENY;
   }
 
-  if (result->IsNumber()) {
-    double num_result = result.As<Number>()->Value();
-    return static_cast<int>(num_result);
+  if (!result->IsNumber()) {
+    return SQLITE_DENY;
+  }
+
+  double num_result = result.As<Number>()->Value();
+  int int_result = static_cast<int>(num_result);
+
+  if (int_result == SQLITE_OK || int_result == SQLITE_DENY ||
+      int_result == SQLITE_IGNORE) {
+    return int_result;
   }
 
-  // Default to OK if the result isn't a number
-  return SQLITE_OK;
+  return SQLITE_DENY;
 }
 
 StatementSync::StatementSync(Environment* env,

test/parallel/test-sqlite-authz.js

@@ -85,6 +85,34 @@ suite('DatabaseSync.prototype.setAuthorizer()', () => {
     });
   });
 
+  it('blocks operations when authorizer returns NaN', () => {
+    const db = new DatabaseSync(':memory:');
+    db.setAuthorizer(() => {
+      return '1';
+    });
+
+    assert.throws(() => {
+      db.exec('SELECT 1');
+    }, {
+      code: 'ERR_SQLITE_ERROR',
+      message: /not authorized/
+    });
+  });
+
+  it('blocks operations when authorizer returns a invalid code', () => {
+    const db = new DatabaseSync(':memory:');
+    db.setAuthorizer(() => {
+      return 3;
+    });
+
+    assert.throws(() => {
+      db.exec('SELECT 1');
+    }, {
+      code: 'ERR_SQLITE_ERROR',
+      message: /not authorized/
+    });
+  });
+
   it('clears authorizer when set to null', (t) => {
     const authorizer = t.mock.fn(() => constants.SQLITE_OK);
     const db = new DatabaseSync(':memory:');
@@ -155,11 +183,4 @@ suite('DatabaseSync.prototype.setAuthorizer()', () => {
       message: /The "callback" argument must be a function/
     });
   });
-
-  it('accepts null as valid input for clearing authorizer', () => {
-    const db = new DatabaseSync(':memory:');
-
-    // does not throw
-    db.setAuthorizer(null);
-  });
 });