test: expand getCACertificates() with 'as' option and invalid inputs

Author: haramj

test/parallel/test-tls-get-ca-certificates-x509-option.js

@@ -1,4 +1,5 @@
 'use strict';
+
 const common = require('../common');
 if (!common.hasCrypto)
   common.skip('missing crypto');
@@ -7,15 +8,55 @@ const assert = require('assert');
 const tls = require('tls');
 const { X509Certificate } = require('crypto');
 
-function testX509Option() {
+{
   const certs = tls.getCACertificates({ type: 'default', as: 'x509' });
 
   assert.ok(Array.isArray(certs), 'should return an array');
   assert.ok(certs.length > 0, 'should return non-empty array');
   assert.ok(certs[0] instanceof X509Certificate,
             'each cert should be instance of X509Certificate');
 
-  assert.match(certs[0].serialNumber, /^[0-9A-F]+$/i, 'serialNumber should be hex string');
+  assert.match(certs[0].serialNumber, /^[0-9A-F]+$/i,
+               'serialNumber should be hex string');
+}
+
+{
+  const certs = tls.getCACertificates({ type: 'default', as: 'buffer' });
+  assert.ok(Array.isArray(certs));
+  assert.ok(certs.length > 0);
+  assert.ok(Buffer.isBuffer(certs[0]));
+}
+
+{
+  const certs = tls.getCACertificates({ type: 'default' });
+  assert.ok(Array.isArray(certs));
+  assert.ok(certs.length > 0);
+  assert.ok(Buffer.isBuffer(certs[0]));
 }
 
-testX509Option();
+{
+  assert.throws(() => {
+    tls.getCACertificates({ type: 'default', as: 'invalid' });
+  }, {
+    name: 'TypeError',
+    code: 'ERR_INVALID_ARG_VALUE',
+    message: /must be one of/
+  });
+}
+
+{
+  const certs = tls.getCACertificates({ as: 'buffer' });
+  assert.ok(Array.isArray(certs));
+  assert.ok(certs.length > 0);
+  assert.ok(Buffer.isBuffer(certs[0]));
+}
+
+{
+  assert.throws(() => {
+    tls.getCACertificates({ type: 'invalid', as: 'buffer' });
+  }, {
+    name: 'TypeError',
+    code: 'ERR_INVALID_ARG_VALUE',
+    message: "The argument 'type' is invalid. Received 'invalid'"
+  });
+}