Skip to content

Commit 2f18a95

Browse files
committed
build: build with v8 gdbjit support on supported platform
Build it with gdbjit support on supported platforms by default allows debugging JIT-compiled code in gdb when it's also enabled at run time (via --gdbjit). Simply building it in should not incur an overhead if it's not also enabled at run time.
1 parent 83ba6b1 commit 2f18a95

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

configure.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1822,7 +1822,16 @@ def configure_v8(o, configs):
18221822
o['variables']['v8_enable_webassembly'] = 0 if options.v8_lite_mode else 1
18231823
o['variables']['v8_enable_javascript_promise_hooks'] = 1
18241824
o['variables']['v8_enable_lite_mode'] = 1 if options.v8_lite_mode else 0
1825-
o['variables']['v8_enable_gdbjit'] = 1 if options.gdb else 0
1825+
is_gdbjit_supported_arch = (
1826+
'x64' in o['variables']['target_arch'] or
1827+
'ia32' in o['variables']['target_arch'] or
1828+
'ppc64' in o['variables']['target_arch']
1829+
)
1830+
is_linux = flavor == 'linux'
1831+
if (options.gdb is not None):
1832+
o['variables']['v8_enable_gdbjit'] = 1 if options.gdb else 0
1833+
else:
1834+
o['variables']['v8_enable_gdbjit'] = 1 if is_gdbjit_supported_arch and is_linux else 0
18261835
o['variables']['v8_optimized_debug'] = 0 if options.v8_non_optimized_debug else 1
18271836
o['variables']['dcheck_always_on'] = 1 if options.v8_with_dchecks else 0
18281837
o['variables']['v8_enable_object_print'] = 0 if options.v8_disable_object_print else 1

0 commit comments

Comments
 (0)