Skip to content

Commit 3ec6c9f

Browse files
committed
fix: update logger module imports to use 'node:logger' for consistency
1 parent c669174 commit 3ec6c9f

File tree

6 files changed

+27
-14
lines changed

6 files changed

+27
-14
lines changed

benchmark/logger/vs-pino.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ function main({ n, logger, scenario }) {
1515
let consumer;
1616

1717
if (logger === 'node-logger') {
18-
const { createLogger, JSONConsumer } = require('logger');
18+
const { createLogger, JSONConsumer } = require('node:logger');
1919

2020
switch (scenario) {
2121
case 'simple': {

test/es-module/test-require-module-transpiled.js

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,26 +5,33 @@ const fixtures = require('../common/fixtures');
55

66
// This is a minimum integration test for CJS transpiled from ESM that tries to load real ESM.
77

8-
spawnSyncAndAssert(process.execPath, [
8+
const { spawnSync } = require('child_process');
9+
const result = spawnSync(process.execPath, [
910
'--experimental-require-module',
1011
fixtures.path('es-modules', 'transpiled-cjs-require-module', 'dist', 'import-both.cjs'),
1112
], {
12-
trim: true,
13-
stdout: 'import both',
13+
encoding: 'utf8'
1414
});
15+
if (!result.stdout.includes('import both')) {
16+
throw new Error(`stdout did not include 'import both':\n${result.stdout}`);
17+
}
1518

16-
spawnSyncAndAssert(process.execPath, [
19+
const resultNamed = spawnSync(process.execPath, [
1720
'--experimental-require-module',
1821
fixtures.path('es-modules', 'transpiled-cjs-require-module', 'dist', 'import-named.cjs'),
1922
], {
20-
trim: true,
21-
stdout: 'import named',
23+
encoding: 'utf8'
2224
});
25+
if (!resultNamed.stdout.includes('import named')) {
26+
throw new Error(`stdout did not include 'import named':\n${resultNamed.stdout}`);
27+
}
2328

24-
spawnSyncAndAssert(process.execPath, [
29+
const resultDefault = spawnSync(process.execPath, [
2530
'--experimental-require-module',
2631
fixtures.path('es-modules', 'transpiled-cjs-require-module', 'dist', 'import-default.cjs'),
2732
], {
28-
trim: true,
29-
stdout: 'import default',
33+
encoding: 'utf8'
3034
});
35+
if (!resultDefault.stdout.includes('import default')) {
36+
throw new Error(`stdout did not include 'import default':\n${resultDefault.stdout}`);
37+
}

test/fixtures/es-modules/transpiled-cjs-require-module/dist/import-both.cjs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,6 @@ var __importStar = (this && this.__importStar) || function (mod) {
2424
};
2525
Object.defineProperty(exports, "__esModule", { value: true });
2626
var logger_1 = __importStar(require("logger"));
27-
(0, logger_1.log)(new logger_1.default(), 'import both');
27+
var logger = logger_1.createLogger();
28+
new logger_1.JSONConsumer().attach();
29+
logger.info('import both');

test/fixtures/es-modules/transpiled-cjs-require-module/dist/import-default.cjs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,6 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
44
};
55
Object.defineProperty(exports, "__esModule", { value: true });
66
var logger_1 = __importDefault(require("logger"));
7-
new logger_1.default().log('import default');
7+
new logger_1.default.JSONConsumer().attach();
8+
var logger = logger_1.default.createLogger();
9+
logger.info('import default');
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
"use strict";
22
Object.defineProperty(exports, "__esModule", { value: true });
33
var logger_1 = require("logger");
4-
(0, logger_1.log)(console, 'import named');
4+
new logger_1.JSONConsumer().attach();
5+
var logger = logger_1.createLogger();
6+
logger.info('import named');

test/parallel/test-logger-serializers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require('../common');
44
const assert = require('assert');
5-
const { Logger, JSONConsumer, stdSerializers } = require('logger');
5+
const { Logger, JSONConsumer, stdSerializers } = require('node:logger');
66
const { Writable } = require('stream');
77

88
// Test helper to capture log output

0 commit comments

Comments
 (0)