test: enforce use of assert.fail via a lint rule

Author: aduh95

test/abort/test-abort-fatal-error.js

@@ -36,7 +36,7 @@ exec(...cmdline, common.mustCall((err, stdout, stderr) => {
   if (!err) {
     console.log(stdout);
     console.log(stderr);
-    assert(false, 'this test should fail');
+    assert.fail('this test should fail');
   }
 
   assert(common.nodeProcessAborted(err.code, err.signal));

test/eslint.config_partial.mjs

@@ -65,6 +65,10 @@ export default [
           selector: "CallExpression[callee.name='assert'][arguments.1.type='Literal']:not([arguments.1.raw=/['\"`].*/])",
           message: 'Do not use a non-string literal for the second argument of assert()',
         },
+        {
+          selector: 'CallExpression:matches([callee.type="Identifier"][callee.name="assert"], [callee.type="MemberExpression"][callee.object.type="Identifier"][callee.object.name="assert"][callee.property.type="Identifier"][callee.property.name="ok"])[arguments.0.type="Literal"]',
+          message: 'Do not use a literal for the first argument of assert(), use assert.fail() instead or remove the call',
+        },
         {
           selector: "CallExpression:matches([callee.name='throws'], [callee.property.name='throws'])[arguments.1.type='Literal']:not([arguments.1.regex])",
           message: 'Use an object as second argument of `assert.throws()`.',

test/message/internal_assert.js

@@ -4,4 +4,4 @@
 require('../common');
 
 const assert = require('internal/assert');
-assert(false);
+assert(2 + 2 > 5);

test/parallel/test-cli-node-options-docs.js

@@ -87,19 +87,19 @@ for (const [, envVar, config] of nodeOptionsCC.matchAll(addOptionRE)) {
   // CLI options
   if (!isV8Option && !hasTrueAsDefaultValue) {
     if (new RegExp(`###.*\`${envVar}[[=\\s\\b\`]`).test(cliText) === false) {
-      assert(false, `Should have option ${envVar} documented`);
+      assert.fail(`Should have option ${envVar} documented`);
     } else {
       manPagesOptions.delete(envVar.slice(1));
     }
   }
 
   if (!hasTrueAsDefaultValue && new RegExp(`###.*\`--no${envVar.slice(1)}[[=\\s\\b\`]`).test(cliText) === true) {
-    assert(false, `Should not have option --no${envVar.slice(1)} documented`);
+    assert.fail(`Should not have option --no${envVar.slice(1)} documented`);
   }
 
   if (!isV8Option && hasTrueAsDefaultValue) {
     if (new RegExp(`###.*\`--no${envVar.slice(1)}[[=\\s\\b\`]`).test(cliText) === false) {
-      assert(false, `Should have option --no${envVar.slice(1)} documented`);
+      assert.fail(`Should have option --no${envVar.slice(1)} documented`);
     } else {
       manPagesOptions.delete(`-no${envVar.slice(1)}`);
     }
@@ -108,21 +108,21 @@ for (const [, envVar, config] of nodeOptionsCC.matchAll(addOptionRE)) {
   // NODE_OPTIONS
   if (isInNodeOption && !hasTrueAsDefaultValue &&
     new RegExp(`\`${envVar}\``).test(nodeOptionsText) === false) {
-    assert(false, `Should have option ${envVar} in NODE_OPTIONS documented`);
+    assert.fail(`Should have option ${envVar} in NODE_OPTIONS documented`);
   }
 
   if (isInNodeOption && hasTrueAsDefaultValue && new RegExp(`\`--no${envVar.slice(1)}\``).test(cliText) === false) {
-    assert(false, `Should have option --no${envVar.slice(1)} in NODE_OPTIONS documented`);
+    assert.fail(`Should have option --no${envVar.slice(1)} in NODE_OPTIONS documented`);
   }
 
   if (!hasTrueAsDefaultValue && new RegExp(`\`--no${envVar.slice(1)}\``).test(cliText) === true) {
-    assert(false, `Should not have option --no${envVar.slice(1)} in NODE_OPTIONS documented`);
+    assert.fail(`Should not have option --no${envVar.slice(1)} in NODE_OPTIONS documented`);
   }
 
   // V8 options
   if (isV8Option) {
     if (new RegExp(`###.*\`${envVar}[[=\\s\\b\`]`).test(v8OptionsText) === false) {
-      assert(false, `Should have option ${envVar} in V8 options documented`);
+      assert.fail(`Should have option ${envVar} in V8 options documented`);
     } else {
       manPagesOptions.delete(envVar.slice(1));
     }

test/parallel/test-cluster-bind-twice.js

@@ -102,7 +102,7 @@ if (!id) {
     }));
   }, 2));
 } else {
-  assert(0); // Bad command line argument
+  assert.fail('Bad command line argument');
 }
 
 function startWorker() {

test/parallel/test-cluster-eaddrinuse.js

@@ -58,5 +58,5 @@ if (id === 'undefined') {
     }));
   }));
 } else {
-  assert(0);  // Bad argument.
+  assert.fail('Bad argument');
 }

test/parallel/test-fastutf8stream-sync.js

@@ -181,10 +181,6 @@ assert.throws(() => {
   assert.ok(stream.write('hello world 👀\n'));
   assert.ok(stream.write('another line 👀\n'));
 
-  // Check internal buffer length (may not be available in Utf8Stream)
-  // This is implementation-specific, so we just verify writes succeeded
-  assert.ok(true, 'writes completed successfully');
-
   stream.end();
 }
 
@@ -200,7 +196,6 @@ assert.throws(() => {
   }
 
   // Check internal buffer length (implementation-specific)
-  assert.ok(true, 'writes completed successfully');
   readFile(dest, 'utf8', common.mustSucceed((data) => {
     assert.strictEqual(data, str);
   }));

test/parallel/test-fs-glob.mjs

@@ -529,7 +529,6 @@ describe('glob - with restricted directory', function() {
       for await (const match of asyncGlob('*', { cwd: restrictedDir })) {
         results.push(match);
       }
-      assert.ok(true, 'glob completed without throwing on readdir error');
     } finally {
       try {
         chmodSync(restrictedDir, 0o755);

test/parallel/test-http.js

@@ -46,7 +46,7 @@ const server = http.Server(common.mustCall((req, res) => {
       assert.strictEqual(req.headers.cookie, 'abc=123; def=456; ghi=789');
       break;
     default:
-      assert(false, `Unexpected request for ${req.url}`);
+      assert.fail(`Unexpected request for ${req.url}`);
   }
 
   if (expectedRequests.length === 0)

test/parallel/test-inspector-network-http2.js

@@ -96,7 +96,7 @@ const handleStream = common.mustCallAtLeast((stream, headers) => {
       }));
       break;
     default:
-      assert(false, `Unexpected path: ${path}`);
+      assert.fail(`Unexpected path: ${path}`);
   }
 });