Skip to content

Commit 41c507f

Browse files
authored
build: update test-wpt-report to use NODE instead of OUT_NODE
PR-URL: #61024 Refs: https://openjs-foundation.slack.com/archives/C03BJP63CH0/p1765400746909869 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 038cb75 commit 41c507f

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

Makefile

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,11 +655,15 @@ test-test426: all ## Run the Web Platform Tests.
655655
test-wpt: all ## Run the Web Platform Tests.
656656
$(PYTHON) tools/test.py $(PARALLEL_ARGS) wpt
657657

658+
# https://github.com/nodejs/node/blob/a00d95c73dcac8fc2b316238fb978a7d5aa650c6/.github/workflows/daily-wpt-fyi.yml#L71-L97
659+
# This uses NODE instead of OUT_NODE and if changes are to be made they'd need to be made on all
660+
# non-EOL release lines' since the wpt.fyi job checks out the repository in a state of a given release
661+
# to ensure future changes to the WPT runner don't need to be backported.
658662
.PHONY: test-wpt-report
659663
test-wpt-report: ## Run the Web Platform Tests and generate a report.
660664
$(RM) -r out/wpt
661665
mkdir -p out/wpt
662-
-WPT_REPORT=1 $(PYTHON) tools/test.py --shell $(OUT_NODE) $(PARALLEL_ARGS) wpt
666+
-WPT_REPORT=1 $(PYTHON) tools/test.py --shell $(NODE) $(PARALLEL_ARGS) wpt
663667
$(NODE) "$$PWD/tools/merge-wpt-reports.mjs"
664668

665669
.PHONY: test-internet

0 commit comments

Comments
 (0)