Skip to content

Commit 45f3a42

Browse files
committed
test: use assert.match for non-literal regexp tests
1 parent 1de8d7f commit 45f3a42

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

test/parallel/test-max-old-space-size-percentage.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,11 @@ invalidPercentages.forEach((input) => {
4141
`--max-old-space-size-percentage=${input[0]}`,
4242
], { stdio: ['pipe', 'pipe', 'pipe'] });
4343
assert.notStrictEqual(result.status, 0, `Expected non-zero exit for invalid input ${input[0]}`);
44-
assert(input[1].test(result.stderr.toString()), `Unexpected error message for invalid input ${input[0]}`);
44+
assert.match(
45+
result.stderr.toString(),
46+
input[1],
47+
`Unexpected error message for invalid input ${input[0]}`
48+
);
4549
});
4650

4751
// Test NODE_OPTIONS with valid percentages
@@ -61,7 +65,11 @@ invalidPercentages.forEach((input) => {
6165
env: { ...process.env, NODE_OPTIONS: `--max-old-space-size-percentage=${input[0]}` }
6266
});
6367
assert.notStrictEqual(result.status, 0, `NODE_OPTIONS: Expected non-zero exit for invalid input ${input[0]}`);
64-
assert(input[1].test(result.stderr.toString()), `NODE_OPTIONS: Unexpected error message for invalid input ${input[0]}`);
68+
assert.match(
69+
result.stderr.toString(),
70+
input[1],
71+
`NODE_OPTIONS: Unexpected error message for invalid input ${input[0]}`
72+
);
6573
});
6674

6775
// Test percentage calculation validation

test/parallel/test-tls-junk-server.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ server.listen(0, common.mustCall(function() {
2828
expectedErrorMessage = new RegExp('packet length too long');
2929
};
3030
req.once('error', common.mustCall(function(err) {
31-
assert(expectedErrorMessage.test(err.message));
31+
assert.match(err.message, expectedErrorMessage);
3232
server.close();
3333
}));
3434
}));

0 commit comments

Comments
 (0)