Skip to content

Commit 48a8c31

Browse files
committed
test: add workaround for the node-options-doc test to make the pipeline pass
fixed the test failure due to its changeable default value. Fixes: #60640
1 parent c89949a commit 48a8c31

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

test/es-module/test-esm-import-meta-main-eval.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const { isMain: importedModuleIsMain } = await import(
3333
assert.strictEqual(importedModuleIsMain, false, 'import.meta.main should evaluate false in imported module');
3434
`;
3535

36-
it('should evaluate true in evaluated script', { skip: !process.config.variables.node_use_amaro }, async () => {
36+
it('should evaluate true in evaluated script', async () => {
3737
const result = await spawnPromisified(
3838
process.execPath,
3939
['--input-type=module', '--eval', importMetaMainScript],
@@ -85,7 +85,7 @@ const { isMain: importedModuleIsMain } = await import(
8585
assert.strictEqual(importedModuleIsMain, false, 'import.meta.main should evaluate false in imported module');
8686
`;
8787

88-
it('should evaluate true in evaluated script', async () => {
88+
it('should evaluate true in evaluated script', { skip: !process.config.variables.node_use_amaro }, async () => {
8989
const result = await spawnPromisified(
9090
process.execPath,
9191
['--input-type=module-typescript', '--disable-warning=ExperimentalWarning', '--eval', importMetaMainTSScript],

test/parallel/test-cli-node-options-docs.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,11 @@ for (const [, envVar, config] of nodeOptionsCC.matchAll(addOptionRE)) {
6363
hasTrueAsDefaultValue = true;
6464
}
6565

66+
// Exception for HAVE_AMARO conditional default (defaults to true when Amaro is available)
67+
if (config.includes('HAVE_AMARO')) {
68+
hasTrueAsDefaultValue = true;
69+
}
70+
6671
if (
6772
envVar.startsWith('[') ||
6873
deprecated.includes(envVar) ||

0 commit comments

Comments
 (0)