Skip to content

Commit 551f605

Browse files
authored
build: build with v8 gdbjit support on supported platform
Build it with gdbjit support on supported platforms by default allows debugging JIT-compiled code in gdb when it's also enabled at run time (via --gdbjit). Simply building it in should not incur an overhead if it's not also enabled at run time. PR-URL: #61010 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent f003f46 commit 551f605

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

configure.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2021,7 +2021,16 @@ def configure_v8(o, configs):
20212021
o['variables']['v8_enable_webassembly'] = 0 if options.v8_lite_mode else 1
20222022
o['variables']['v8_enable_javascript_promise_hooks'] = 1
20232023
o['variables']['v8_enable_lite_mode'] = 1 if options.v8_lite_mode else 0
2024-
o['variables']['v8_enable_gdbjit'] = 1 if options.gdb else 0
2024+
is_gdbjit_supported_arch = (
2025+
'x64' in o['variables']['target_arch'] or
2026+
'ia32' in o['variables']['target_arch'] or
2027+
'ppc64' in o['variables']['target_arch']
2028+
)
2029+
is_linux = flavor == 'linux'
2030+
if (options.gdb is not None):
2031+
o['variables']['v8_enable_gdbjit'] = 1 if options.gdb else 0
2032+
else:
2033+
o['variables']['v8_enable_gdbjit'] = 1 if is_gdbjit_supported_arch and is_linux else 0
20252034
o['variables']['v8_optimized_debug'] = 0 if options.v8_non_optimized_debug else 1
20262035
o['variables']['dcheck_always_on'] = 1 if options.v8_with_dchecks else 0
20272036
o['variables']['v8_enable_object_print'] = 0 if options.v8_disable_object_print else 1

0 commit comments

Comments
 (0)