Skip to content

Commit 5bdffbb

Browse files
committed
fix order
1 parent 4bff794 commit 5bdffbb

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

doc/api/n-api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2270,11 +2270,11 @@ typedef enum {
22702270
napi_uint16_array,
22712271
napi_int32_array,
22722272
napi_uint32_array,
2273+
napi_float16_array,
22732274
napi_float32_array,
22742275
napi_float64_array,
22752276
napi_bigint64_array,
22762277
napi_biguint64_array,
2277-
napi_float16_array
22782278
} napi_typedarray_type;
22792279
```
22802280

src/js_native_api_types.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,11 +101,11 @@ typedef enum {
101101
napi_uint16_array,
102102
napi_int32_array,
103103
napi_uint32_array,
104+
napi_float16_array,
104105
napi_float32_array,
105106
napi_float64_array,
106107
napi_bigint64_array,
107108
napi_biguint64_array,
108-
napi_float16_array,
109109
} napi_typedarray_type;
110110

111111
typedef enum {

src/js_native_api_v8.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3207,6 +3207,8 @@ napi_status NAPI_CDECL napi_get_typedarray_info(napi_env env,
32073207
*type = napi_int32_array;
32083208
} else if (value->IsUint32Array()) {
32093209
*type = napi_uint32_array;
3210+
} else if (value->IsFloat16Array()) {
3211+
*type = napi_float16_array;
32103212
} else if (value->IsFloat32Array()) {
32113213
*type = napi_float32_array;
32123214
} else if (value->IsFloat64Array()) {
@@ -3215,8 +3217,6 @@ napi_status NAPI_CDECL napi_get_typedarray_info(napi_env env,
32153217
*type = napi_bigint64_array;
32163218
} else if (value->IsBigUint64Array()) {
32173219
*type = napi_biguint64_array;
3218-
} else if (value->IsFloat16Array()) {
3219-
*type = napi_float16_array;
32203220
}
32213221
}
32223222

test/js-native-api/test_typedarray/test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ assert.strictEqual(externalResult[2], 2);
4141
// Validate creation of all kinds of TypedArrays
4242
const buffer = new ArrayBuffer(128);
4343
const arrayTypes = [ Int8Array, Uint8Array, Uint8ClampedArray, Int16Array,
44-
Uint16Array, Int32Array, Uint32Array, Float32Array,
45-
Float64Array, BigInt64Array, BigUint64Array, Float16Array ];
44+
Uint16Array, Int32Array, Uint32Array, Float16Array,
45+
Float32Array, Float64Array, BigInt64Array, BigUint64Array ];
4646

4747
arrayTypes.forEach((currentType) => {
4848
const template = Reflect.construct(currentType, buffer);
@@ -64,8 +64,8 @@ arrayTypes.forEach((currentType) => {
6464
});
6565

6666
const nonByteArrayTypes = [ Int16Array, Uint16Array, Int32Array, Uint32Array,
67-
Float32Array, Float64Array,
68-
BigInt64Array, BigUint64Array, Float16Array ];
67+
Float16Array, Float32Array, Float64Array,
68+
BigInt64Array, BigUint64Array ];
6969
nonByteArrayTypes.forEach((currentType) => {
7070
const template = Reflect.construct(currentType, buffer);
7171
assert.throws(() => {

0 commit comments

Comments
 (0)