src: enhance error messages for unknown options

PR-URL: #58677
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: pmarchini

src/node_config_file.cc

@@ -200,7 +200,7 @@ ParseResult ConfigReader::ParseOptions(
     } else {
       FPrintF(stderr,
               "Unknown or not allowed option %s for namespace %s\n",
-              option_key.data(),
+              option_key,
               namespace_name.c_str());
       return ParseResult::InvalidContent;
     }

test/parallel/test-config-file.js

@@ -160,7 +160,7 @@ test('should throw at unknown flag', async () => {
     fixtures.path('rc/unknown-flag.json'),
     '-p', '"Hello, World!"',
   ]);
-  match(result.stderr, /Unknown or not allowed option some-unknown-flag/);
+  match(result.stderr, /Unknown or not allowed option some-unknown-flag for namespace nodeOptions/);
   strictEqual(result.stdout, '');
   strictEqual(result.code, 9);
 });
@@ -172,7 +172,7 @@ test('should throw at flag not available in NODE_OPTIONS', async () => {
     fixtures.path('rc/not-node-options-flag.json'),
     '-p', '"Hello, World!"',
   ]);
-  match(result.stderr, /Unknown or not allowed option test/);
+  match(result.stderr, /Unknown or not allowed option test for namespace nodeOptions/);
   strictEqual(result.stdout, '');
   strictEqual(result.code, 9);
 });
@@ -411,7 +411,7 @@ describe('namespace-scoped options', () => {
       fixtures.path('rc/unknown-flag-namespace.json'),
       '-p', '"Hello, World!"',
     ]);
-    match(result.stderr, /Unknown or not allowed option unknown-flag/);
+    match(result.stderr, /Unknown or not allowed option unknown-flag for namespace testRunner/);
     strictEqual(result.stdout, '');
     strictEqual(result.code, 9);
   });