Skip to content

Commit 60a58f6

Browse files
committed
src: mark realm leaf classes final
Since these classes use virtual methods extensively, adding `final` should allow compilers to optimize accesses better. PR-URL: #59355 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
1 parent 3f6f6db commit 60a58f6

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/node_realm.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ class Realm : public MemoryRetainer {
209209
CppgcWrapperList cppgc_wrapper_list_;
210210
};
211211

212-
class PrincipalRealm : public Realm {
212+
class PrincipalRealm final : public Realm {
213213
public:
214214
PrincipalRealm(Environment* env,
215215
v8::Local<v8::Context> context,

src/node_shadow_realm.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
namespace node {
1010
namespace shadow_realm {
1111

12-
class ShadowRealm : public Realm {
12+
class ShadowRealm final : public Realm {
1313
public:
1414
static ShadowRealm* New(Environment* env);
1515

0 commit comments

Comments
 (0)