url: add type checking to urlToHttpOptions()

PR-URL: #59753
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Bryan English <[email protected]>

Author: simon-id

lib/internal/url.js

@@ -91,6 +91,8 @@ const { Buffer } = require('buffer');
 
 const {
   validateFunction,
+  validateObject,
+  kValidateObjectAllowObjects,
 } = require('internal/validators');
 
 const { percentDecode } = require('internal/data_url');
@@ -1431,6 +1433,7 @@ function domainToUnicode(domain) {
  * @returns {Record<string, unknown>}
  */
 function urlToHttpOptions(url) {
+  validateObject(url, 'url', kValidateObjectAllowObjects);
   const { hostname, pathname, port, username, password, search } = url;
   const options = {
     __proto__: null,

test/parallel/test-url-urltooptions.js

@@ -35,3 +35,12 @@ assert.strictEqual(copiedOpts.pathname, undefined);
 assert.strictEqual(copiedOpts.search, undefined);
 assert.strictEqual(copiedOpts.hash, undefined);
 assert.strictEqual(copiedOpts.href, undefined);
+
+// Test when passed an invalid argument
+assert.throws(() => {
+  urlToHttpOptions('http://127.0.0.1');
+}, {
+  code: 'ERR_INVALID_ARG_TYPE',
+  message: 'The "url" argument must be of type object. Received type string (\'http://127.0.0.1\')',
+  name: 'TypeError'
+});