Skip to content

Commit 709e9ce

Browse files
committed
refactor: remove decodeLatin1 function and related tests
1 parent 3b2bb9b commit 709e9ce

File tree

3 files changed

+0
-7
lines changed

3 files changed

+0
-7
lines changed

src/encoding_binding.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,6 @@ void BindingData::CreatePerIsolateProperties(IsolateData* isolate_data,
221221
SetMethodNoSideEffect(isolate, target, "decodeUTF8", DecodeUTF8);
222222
SetMethodNoSideEffect(isolate, target, "toASCII", ToASCII);
223223
SetMethodNoSideEffect(isolate, target, "toUnicode", ToUnicode);
224-
// decodeLatin1 binding removed
225224
SetMethodNoSideEffect(
226225
isolate, target, "decodeWindows1252", DecodeWindows1252);
227226
}
@@ -241,12 +240,9 @@ void BindingData::RegisterTimerExternalReferences(
241240
registry->Register(DecodeUTF8);
242241
registry->Register(ToASCII);
243242
registry->Register(ToUnicode);
244-
// DecodeLatin1 registration removed
245243
registry->Register(DecodeWindows1252);
246244
}
247245

248-
// DecodeLatin1 implementation removed
249-
250246
void BindingData::DecodeWindows1252(const FunctionCallbackInfo<Value>& args) {
251247
Environment* env = Environment::GetCurrent(args);
252248

src/encoding_binding.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ class BindingData : public SnapshotableObject {
3131
static void EncodeInto(const v8::FunctionCallbackInfo<v8::Value>& args);
3232
static void EncodeUtf8String(const v8::FunctionCallbackInfo<v8::Value>& args);
3333
static void DecodeUTF8(const v8::FunctionCallbackInfo<v8::Value>& args);
34-
// DecodeLatin1 removed: no longer used
3534
static void DecodeWindows1252(
3635
const v8::FunctionCallbackInfo<v8::Value>& args);
3736

test/parallel/test-internal-encoding-binding.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ const assert = require('node:assert');
88
const { internalBinding } = require('internal/test/binding');
99
const binding = internalBinding('encoding_binding');
1010

11-
// decodeLatin1 tests removed: function no longer exists
12-
1311
// Windows-1252 specific tests
1412
{
1513
// Test Windows-1252 special characters in 128-159 range

0 commit comments

Comments
 (0)